Bug 1326374
| Summary: | several files out-of-sync | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Qian Cai <qcai> |
| Component: | docker-latest | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | atomic-bugs <atomic-bugs> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.2 | Keywords: | Extras, ZStream |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | docker-1.10.3-19.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-12 14:54:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Qian Cai
2016-04-12 14:32:05 UTC
That's expected behavior for sysconfig files if they've been edited from defaults. Could you do a clean install and then remove those packages without editing them and confirm if the files still exist? My point was, If docker-storage was modified, it will be renamed to docker-storage.rpmsave after removed docker rpm. If docker-latest-storage was modified, it will NOT be renamed docker-latest-storage.rpmsave after removed docker-latest rpm. After a fresh installation, they have different layout, # ls /etc/sysconfig/docker-storage* /etc/sysconfig/docker-storage /etc/sysconfig/docker-storage-setup # ls /etc/sysconfig/docker-latest-storage* /etc/sysconfig/docker-latest-storage-setup /etc/sysconfig/docker-latest-storage.sysconfig Why docker-latest has docker-latest-storage.sysconfig instead of docker-latest-storage by default? I think the issue could be related, # rpm -ql docker-latest | grep \\.sysconfig /etc/sysconfig/docker-latest-network.sysconfig /etc/sysconfig/docker-latest-storage.sysconfig /etc/sysconfig/docker-latest.sysconfig As the results, none of changes made into those files have any effect to docker-latest until renamed to files without .sysconfig suffix. Ah I see I didn't rename the files while installing them. I'll fix that in the next build. Sorry I got confused earlier. One more issue is that both docker-latest and docker-latest-novolume-plugin provide those files, /usr/lib/systemd/system/docker-latest-novolume-plugin.service /usr/lib/systemd/system/docker-latest-novolume-plugin.socket /usr/share/man/man8/docker-latest-novolume-plugin.8.gz Last but not least, below patch is needed, # diff -u /usr/lib/systemd/system/docker-latest-novolume-plugin.service.orig /usr/lib/systemd/system/docker-latest-novolume-plugin.service --- /usr/lib/systemd/system/docker-latest-novolume-plugin.service.orig 2016-04-13 11:42:22.695600675 -0400 +++ /usr/lib/systemd/system/docker-latest-novolume-plugin.service 2016-04-13 11:55:22.094600675 -0400 @@ -1,13 +1,13 @@ [Unit] Description=Docker No volumes authZ Plugin Documentation=man:docker-novolume-plugin(8) -Before=docker.service -After=network.target docker-novolume-plugin.socket -Requires=docker-novolume-plugin.socket docker.service +Before=docker-latest.service +After=network.target docker-latest-novolume-plugin.socket +Requires=docker-latest-novolume-plugin.socket docker-latest.service [Service] # might need to set flags... -ExecStart=/usr/libexec/docker/docker-novolume-plugin +ExecStart=/usr/lib/docker-latest/docker-latest-novolume-plugin [Install] WantedBy=multi-user.target fixed in upcoming ... Everything is fixed except one mismatch. # rpm -ql docker-latest-novolume-plugin /usr/lib/docker-latest/docker-latest-novolume-plugin ... # cat /usr/lib/systemd/system/docker-latest-novolume-plugin.service ExecStart=/usr/libexec/docker-latest/docker-latest-novolume-plugin Same thing for docker-latest-lvm-plugin as well, # rpm -ql docker-latest-lvm-plugin /usr/lib/docker-latest/docker-latest-lvm-plugin ... # cat /usr/lib/systemd/system/docker-latest-lvm-plugin.service ... ExecStart=/usr/libexec/docker-latest/docker-latest-lvm-plugin ... This still does not look right.
# rpm -qa | grep docker
docker-rhel-push-plugin-1.10.3-18.el7.x86_64
docker-1.9.1-38.el7.x86_64
docker-common-1.9.1-38.el7.x86_64
docker-selinux-1.9.1-38.el7.x86_64
docker-latest-1.10.3-18.el7.x86_64
docker-novolume-plugin-1.10.3-18.el7.x86_64
docker-forward-journald-1.9.1-38.el7.x86_64
docker-lvm-plugin-1.10.3-18.el7.x86_64
# rpm -ql docker-lvm-plugin-1.10.3-18.el7
...
/usr/libexec/docker/docker-lvm-plugin
...
/usr/share/man/man8/docker-lvm-plugin.8.gz
# cat /usr/lib/systemd/system/docker-lvm-plugin.service
...
Documentation=man:docker-latest-lvm-plugin(8) <<< strip "-latest"?
Before=docker-latest.service
[Service]
Type=simple
EnvironmentFile=-/etc/docker-latest/docker-latest-lvm-plugin <<< ditto?
ExecStart=/usr/libexec/docker-latest/docker-latest-lvm-plugin <<< ditto?
...
# rpm -ql docker-novolume-plugin
...
/usr/libexec/docker/docker-novolume-plugin
...
/usr/share/man/man8/docker-novolume-plugin.8.gz
# cat /usr/lib/systemd/system/docker-novolume-plugin.service
...
Documentation=man:docker-latest-novolume-plugin(8) <<< ditto?
Before=docker-latest.service
After=network.target docker-latest-novolume-plugin.socket <<< ditto?
Requires=docker-latest-novolume-plugin.socket docker-latest.service
^^^^ should be docker-novolume-plugin.socket?
[Service]
# might need to set flags...
ExecStart=/usr/libexec/docker-latest/docker-latest-novolume-plugin
^^^^ strip "-latest"?
...
Worked fine with the combo. # rpm -qa | grep docker docker-forward-journald-1.9.1-38.el7.x86_64 docker-selinux-1.9.1-38.el7.x86_64 docker-common-1.9.1-38.el7.x86_64 docker-rhel-push-plugin-1.10.3-19.el7.x86_64 docker-latest-1.10.3-19.el7.x86_64 docker-lvm-plugin-1.10.3-19.el7.x86_64 docker-1.9.1-38.el7.x86_64 docker-novolume-plugin-1.10.3-19.el7.x86_64 could you please move it to VERIFIED once confirmed? CAI, could you remove the FailedQA/Any status please? I'm not sure how to uncheck all of them. Just Ctrl + click will do. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-1057.html |