Bug 1326374 - several files out-of-sync
Summary: several files out-of-sync
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: docker-latest
Version: 7.2
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Lokesh Mandvekar
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-12 14:32 UTC by Qian Cai
Modified: 2016-05-12 14:54 UTC (History)
0 users

Fixed In Version: docker-1.10.3-19.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-12 14:54:43 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:1057 0 normal SHIPPED_LIVE new packages: docker-latest 2016-05-12 18:51:24 UTC

Description Qian Cai 2016-04-12 14:32:05 UTC
Description of problem:
# rpm -e docker-latest
warning: /etc/sysconfig/docker-latest-storage-setup saved as /etc/sysconfig/docker-latest-storage-setup.rpmsave
# ls /etc/sysconfig/docker-latest-storage
/etc/sysconfig/docker-latest-storage

# rpm -e docker
warning: /etc/sysconfig/docker-storage-setup saved as /etc/sysconfig/docker-storage-setup.rpmsave
warning: /etc/sysconfig/docker-storage saved as /etc/sysconfig/docker-storage.rpmsave

Version-Release number of selected component (if applicable):
docker-latest-1.10.3-9.el7.x86_64

How reproducible:
always

Comment 2 Lokesh Mandvekar 2016-04-12 15:10:32 UTC
That's expected behavior for sysconfig files if they've been edited from defaults.

Could you do a clean install and then remove those packages without editing them and confirm if the files still exist?

Comment 3 Qian Cai 2016-04-12 15:41:50 UTC
My point was,

If docker-storage was modified, it will be renamed to docker-storage.rpmsave after removed docker rpm.

If docker-latest-storage was modified, it will NOT be renamed docker-latest-storage.rpmsave after removed docker-latest rpm.

After a fresh installation, they have different layout,

# ls /etc/sysconfig/docker-storage*
/etc/sysconfig/docker-storage
/etc/sysconfig/docker-storage-setup

# ls /etc/sysconfig/docker-latest-storage*
/etc/sysconfig/docker-latest-storage-setup
/etc/sysconfig/docker-latest-storage.sysconfig

Why docker-latest has docker-latest-storage.sysconfig instead of docker-latest-storage by default?

Comment 4 Qian Cai 2016-04-12 16:44:02 UTC
I think the issue could be related,

# rpm -ql docker-latest | grep \\.sysconfig
/etc/sysconfig/docker-latest-network.sysconfig
/etc/sysconfig/docker-latest-storage.sysconfig
/etc/sysconfig/docker-latest.sysconfig

As the results, none of changes made into those files have any effect to docker-latest until renamed to files without .sysconfig suffix.

Comment 5 Lokesh Mandvekar 2016-04-12 17:03:34 UTC
Ah I see I didn't rename the files while installing them. I'll fix that in the next build. Sorry I got confused earlier.

Comment 6 Qian Cai 2016-04-13 15:58:51 UTC
One more issue is that both docker-latest and docker-latest-novolume-plugin provide those files,

/usr/lib/systemd/system/docker-latest-novolume-plugin.service
/usr/lib/systemd/system/docker-latest-novolume-plugin.socket
/usr/share/man/man8/docker-latest-novolume-plugin.8.gz

Comment 7 Qian Cai 2016-04-13 16:00:10 UTC
Last but not least, below patch is needed,

# diff -u /usr/lib/systemd/system/docker-latest-novolume-plugin.service.orig /usr/lib/systemd/system/docker-latest-novolume-plugin.service
--- /usr/lib/systemd/system/docker-latest-novolume-plugin.service.orig	2016-04-13 11:42:22.695600675 -0400
+++ /usr/lib/systemd/system/docker-latest-novolume-plugin.service	2016-04-13 11:55:22.094600675 -0400
@@ -1,13 +1,13 @@
 [Unit]
 Description=Docker No volumes authZ Plugin
 Documentation=man:docker-novolume-plugin(8)
-Before=docker.service
-After=network.target docker-novolume-plugin.socket
-Requires=docker-novolume-plugin.socket docker.service
+Before=docker-latest.service
+After=network.target docker-latest-novolume-plugin.socket
+Requires=docker-latest-novolume-plugin.socket docker-latest.service
 
 [Service]
 # might need to set flags...
-ExecStart=/usr/libexec/docker/docker-novolume-plugin
+ExecStart=/usr/lib/docker-latest/docker-latest-novolume-plugin
 
 [Install]
 WantedBy=multi-user.target

Comment 8 Lokesh Mandvekar 2016-04-18 16:53:45 UTC
fixed in upcoming ...

Comment 10 Qian Cai 2016-04-19 17:53:09 UTC
Everything is fixed except one mismatch.

# rpm -ql docker-latest-novolume-plugin
/usr/lib/docker-latest/docker-latest-novolume-plugin
...

# cat /usr/lib/systemd/system/docker-latest-novolume-plugin.service
ExecStart=/usr/libexec/docker-latest/docker-latest-novolume-plugin

Comment 11 Qian Cai 2016-04-19 18:41:22 UTC
Same thing for docker-latest-lvm-plugin as well,

# rpm -ql docker-latest-lvm-plugin
/usr/lib/docker-latest/docker-latest-lvm-plugin
...

# cat /usr/lib/systemd/system/docker-latest-lvm-plugin.service
...
ExecStart=/usr/libexec/docker-latest/docker-latest-lvm-plugin
...

Comment 12 Qian Cai 2016-04-27 19:20:09 UTC
This still does not look right.

# rpm -qa | grep docker
docker-rhel-push-plugin-1.10.3-18.el7.x86_64
docker-1.9.1-38.el7.x86_64
docker-common-1.9.1-38.el7.x86_64
docker-selinux-1.9.1-38.el7.x86_64
docker-latest-1.10.3-18.el7.x86_64
docker-novolume-plugin-1.10.3-18.el7.x86_64
docker-forward-journald-1.9.1-38.el7.x86_64
docker-lvm-plugin-1.10.3-18.el7.x86_64

# rpm -ql docker-lvm-plugin-1.10.3-18.el7
...
/usr/libexec/docker/docker-lvm-plugin
...
/usr/share/man/man8/docker-lvm-plugin.8.gz

# cat /usr/lib/systemd/system/docker-lvm-plugin.service
...
Documentation=man:docker-latest-lvm-plugin(8) <<< strip "-latest"?
Before=docker-latest.service

[Service]
Type=simple
EnvironmentFile=-/etc/docker-latest/docker-latest-lvm-plugin <<< ditto?
ExecStart=/usr/libexec/docker-latest/docker-latest-lvm-plugin <<< ditto?
...

# rpm -ql docker-novolume-plugin
...
/usr/libexec/docker/docker-novolume-plugin
...
/usr/share/man/man8/docker-novolume-plugin.8.gz

# cat /usr/lib/systemd/system/docker-novolume-plugin.service
...
Documentation=man:docker-latest-novolume-plugin(8) <<< ditto?
Before=docker-latest.service
After=network.target docker-latest-novolume-plugin.socket <<< ditto?
Requires=docker-latest-novolume-plugin.socket docker-latest.service
                        ^^^^ should be docker-novolume-plugin.socket?

[Service]
# might need to set flags...
ExecStart=/usr/libexec/docker-latest/docker-latest-novolume-plugin
                       ^^^^ strip "-latest"?
...

Comment 14 Qian Cai 2016-05-02 16:15:29 UTC
Worked fine with the combo.

# rpm -qa | grep docker
docker-forward-journald-1.9.1-38.el7.x86_64
docker-selinux-1.9.1-38.el7.x86_64
docker-common-1.9.1-38.el7.x86_64
docker-rhel-push-plugin-1.10.3-19.el7.x86_64
docker-latest-1.10.3-19.el7.x86_64
docker-lvm-plugin-1.10.3-19.el7.x86_64
docker-1.9.1-38.el7.x86_64
docker-novolume-plugin-1.10.3-19.el7.x86_64

Comment 15 Lokesh Mandvekar 2016-05-02 19:05:04 UTC
could you please move it to VERIFIED once confirmed?

Comment 16 Lokesh Mandvekar 2016-05-04 17:28:35 UTC
CAI, could you remove the FailedQA/Any status please? I'm not sure how to uncheck all of them.

Comment 17 Qian Cai 2016-05-04 17:43:25 UTC
Just Ctrl + click will do.

Comment 19 errata-xmlrpc 2016-05-12 14:54:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1057.html


Note You need to log in before you can comment on or make changes to this bug.