Created attachment 1146911 [details] build.log Build of golang-googlecode-net fails on s390x that uses gcc-go with tons of errors ... + go test -compiler gccgo -gccgoflags '-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -march=z9-109 -mtune=z10 ' golang.org/x/net/ipv4 # golang.org/x/net/ipv4 ../../BUILDROOT/golang-googlecode-net-0-0.31.git6acef71.fc24.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/icmp.go:34:2: error: use of undefined type 'sysICMPFilter' sysICMPFilter ^ ../../BUILDROOT/golang-googlecode-net-0-0.31.git6acef71.fc24.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/control_pktinfo.go:19:11: error: reference to undefined name 'sysIP_PKTINFO' m.Type = sysIP_PKTINFO ^ ../../BUILDROOT/golang-googlecode-net-0-0.31.git6acef71.fc24.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/control_pktinfo.go:20:27: error: reference to undefined name 'sysSizeofInetPktinfo' ... see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2183406 for full logs, or attachment for build.log Version-Release number of selected component (if applicable): golang-googlecode-net-0-0.31.git6acef71.fc24
ipv4]$ grep -rn "type sysICMPFilter" zsys_linux_amd64.go:130:type sysICMPFilter struct { icmp_stub.go:11:type sysICMPFilter struct { zsys_linux_arm64.go:132:type sysICMPFilter struct { defs_linux.go:111:type sysICMPFilter C.struct_icmp_filter zsys_linux_mips64le.go:132:type sysICMPFilter struct { zsys_linux_mips64.go:132:type sysICMPFilter struct { zsys_linux_386.go:128:type sysICMPFilter struct { zsys_linux_ppc64le.go:132:type sysICMPFilter struct { zsys_linux_ppc64.go:132:type sysICMPFilter struct { zsys_linux_arm.go:128:type sysICMPFilter struct { Can't see s390x among supported architectures for this package. Checking the upstream [1] the support is still missing. [1] https://github.com/golang/net/tree/master/ipv4
The files are generated with "cgo" if I see correctly, how difficult would be to add the s390x variant? Do we have the tool needed (we even have golang now on s390x)? How about upstream acceptance?
Created attachment 1147705 [details] add s390x support something like that should add the missing s390x support, but it fails to build for me, it exceeds my Go foo :-)
Thanks for the patch. I will take a look at it.
scratch build with applied http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2187433
Seems recent upstream already contains s390x support, please make an update in Fedora too.
Still the same issue [1]: "/tmp/go-build546930784/golang.org/x/net/libipv4.a(_go_.o): In function `golang_org_x_net_ipv4.set.pN28_golang_org_x_net_ipv4.rawOpt': /builddir/build/BUILDROOT/golang-googlecode-net-0-0.32.gitbc3663d.fc25.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/control.go:18: multiple definition of `golang_org_x_net_ipv4.set.pN28_golang_org_x_net_ipv4.rawOpt'" [1] http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2266793
We have switched to golang on s390x now, so please do the update to recent version.
$ gofed apidiff --reference=upstream:github.com/golang/net:4d38db76854b199960801a1734443fd02870d7e1 --compare-with=upstream:github.com/golang/net:6acef71eb69611914f7a30939ea9f6e194c78172 -ca +http2: new function: Err +http2: new function: pipe.Len +http2: new function: sorter.Less +http2: new function: sorter.Keys +http2: new function: GoAwayError.Error +http2: new function: sorter.Len +http2: new function: sorter.Swap +http2: new function: Done +http2: new function: sorter.SortStrings +http2: new function: ValidTrailerHeader +http2: new type: GoAwayError ~http2: type updated: +struct werr: new field 'lastActive' ~http2: type updated: +struct werr: new field 'goAwayDebug' ~http2: type updated: +struct werr: new field 'singleUse' ~http2: type updated: +struct connPoolOrDef: new field 'AllowHTTP' +ipv4: new function: dgramOpt.SetBPF +ipv6: new function: dgramOpt.SetBPF ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml ~webdav: function updated: -identifiers differ in type: xml != ixml - looks like the current commit and the latest are compatible. - local build on x86_64 is ok - scratch build on s390x ok: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2297684 - scratch build on ppc64 ok: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3552550 - scratch build on primary archs ok: http://koji.fedoraproject.org/koji/taskinfo?taskID=15012774
golang-googlecode-net-0-0.33.git4d38db7.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9eb5699e28
golang-googlecode-net-0-0.33.git4d38db7.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2b97ecadbf
golang-googlecode-net-0-0.33.git4d38db7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a15d7c860d
golang-googlecode-net-0-0.33.git4d38db7.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2b97ecadbf
golang-googlecode-net-0-0.33.git4d38db7.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9eb5699e28
golang-googlecode-net-0-0.33.git4d38db7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a15d7c860d
golang-googlecode-net-0-0.33.git4d38db7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.33.git4d38db7.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.34.git4d38db7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-276536f1a6
golang-googlecode-net-0-0.34.git4d38db7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-276536f1a6
golang-googlecode-net-0-0.35.git4d38db7.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-294468a279
golang-googlecode-net-0-0.35.git4d38db7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-92e44d8c16
golang-googlecode-net-0-0.35.git4d38db7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9e6c2dee66
golang-googlecode-net-0-0.35.git4d38db7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3675b2c8c1
golang-googlecode-net-0-0.35.git4d38db7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9e6c2dee66
golang-googlecode-net-0-0.35.git4d38db7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3675b2c8c1
golang-googlecode-net-0-0.35.git4d38db7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-92e44d8c16
golang-googlecode-net-0-0.35.git4d38db7.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-294468a279
golang-googlecode-net-0-0.12.hg84a4013f96e0.el7 is in rhel7. Please retire package on epel7.
golang-googlecode-net-0-0.35.git4d38db7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.35.git4d38db7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.35.git4d38db7.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.37.gitf249948.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a6b494e1a
golang-googlecode-net-0-0.37.gitf249948.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7b6f1744c8
golang-googlecode-net-0-0.37.gitf249948.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ecceded7e9
golang-googlecode-net-0-0.37.gitf249948.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a6b494e1a
golang-googlecode-net-0-0.37.gitf249948.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ecceded7e9
golang-googlecode-net-0-0.37.gitf249948.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7b6f1744c8
This message is a reminder that Fedora 24 is nearing its end of life. Approximately 2 (two) weeks from now Fedora will stop maintaining and issuing updates for Fedora 24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '24'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 24 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
golang-googlecode-net-0-0.40.git1c05540.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-655fc4d7de
golang-googlecode-net-0-0.40.git1c05540.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5ef68b86b4
golang-googlecode-net-0-0.40.git1c05540.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-133c63ab59
golang-googlecode-net-0-0.40.git1c05540.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-655fc4d7de
golang-googlecode-net-0-0.40.git1c05540.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-133c63ab59
golang-googlecode-net-0-0.40.git1c05540.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5ef68b86b4
golang-googlecode-net-0-0.40.git1c05540.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1dff2f54cc
golang-googlecode-net-0-0.40.git1c05540.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1dff2f54cc
Could a build for EPEL7 be pushed as well?
golang-googlecode-net-0-0.43.20180308git66aacef.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-57ec52532e
golang-googlecode-net-0-0.43.20180308git66aacef.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-35dff1dffd
golang-googlecode-net-0-0.43.20180308git66aacef.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-57ec52532e
golang-googlecode-net-0-0.43.20180308git66aacef.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-35dff1dffd
This bug is currently reported against a Fedora version which is already unsuported. I am changing the version to '27', the latest supported release. Please check whether this bug is still an issue on the '27' release. If you find this bug not being applicable on this release, please close it.
golang-googlecode-net-0-0.46.20180614gitdb08ff0.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-732e8715dd
golang-googlecode-net-0-0.46.20180614gitdb08ff0.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d1e3543581
golang-googlecode-net-0-0.46.20180614gitdb08ff0.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-732e8715dd
golang-googlecode-net-0-0.46.20180614gitdb08ff0.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d1e3543581
golang-googlecode-net-0-0.46.20180614gitdb08ff0.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-net-0-0.46.20180614gitdb08ff0.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.