Created attachment 1146918 [details] build.log Build fails on s390x with gcc-go, probably -lpthread missing from the LDFLAGS. ... +++ echo 'Building: bundles/1.10.3/dynbinary/docker-1.10.3' +++ go build -o bundles/1.10.3/dynbinary/docker-1.10.3 -a -tags 'autogen sqlite_omit_load_extension selinux seccomp daemon journald' -installsuffix netgo -ldflags ' -w ' ./docker Building: bundles/1.10.3/dynbinary/docker-1.10.3 go build: when using gccgo toolchain, please pass linker flags using -gccgoflags, not -ldflags # _/builddir/build/BUILD/docker-f8a9a2a9fee151828f9deed04cb40e88bc3b2f56/docker /usr/bin/ld: $WORK/libgo-sqlite3.a452538637(sqlite3-binding.o): undefined reference to symbol 'pthread_mutexattr_settype@@GLIBC_2.2' /usr/lib64/libpthread.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.OxHW3Z (%build) Bad exit status from /var/tmp/rpm-tmp.OxHW3Z (%build) ... For full logs please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2183419 or attachment for build.log. Version-Release number of selected component (if applicable): docker-1.10.3-4.gitf8a9a2a.fc24
I think we saw this problem with sqlite3 and -lpthread earlier, but don't know if there was a solution.
Created attachment 1164091 [details] docker s390x build fix Reason of build failure on s390x was indeed missing linkage to pthread library. Attached patch fixes the build issue. F24 scratch build for s390x - http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2250068 Also, did scratch build for primary arches (http://koji.fedoraproject.org/koji/taskinfo?taskID=14352619) and powerpc (http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3429464). Docker build for all architectures looks good.
Maybe the patch can be applied unconditionally, because it should affect only gcc-go based builds and it's only s390x.
(In reply to Dan Horák from comment #3) > Maybe the patch can be applied unconditionally, because it should affect > only gcc-go based builds and it's only s390x. In ExclusiveArch section of docker spec file, it also includes %{mips} and %{ix86} architectures. Do they also use golang package instead of gcc-go ?
(In reply to Sinny Kumari from comment #4) > (In reply to Dan Horák from comment #3) > > Maybe the patch can be applied unconditionally, because it should affect > > only gcc-go based builds and it's only s390x. > > In ExclusiveArch section of docker spec file, it also includes %{mips} and > %{ix86} architectures. Do they also use golang package instead of gcc-go ? [sharkcz@devel10 ~]$ rpmbuild --eval %gccgo_arches s390x mips mipsel mipsr6 mipsr6el mips64 mips64el mips64r6 mips64r6el so %{ix86} is golang, but mips is gcc-go (based on F-24 values)
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
docker-1.10.3-19.gitee81b72.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0e7173e52
docker-1.10.3-19.gitee81b72.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0e7173e52
docker-1.10.3-19.gitee81b72.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.