Bug 1327035 - fuse: Avoid redundant lookup on "." and ".." as part of every readdirp
Summary: fuse: Avoid redundant lookup on "." and ".." as part of every readdirp
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: fuse
Version: rhgs-3.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHGS 3.1.3
Assignee: Bug Updates Notification Mailing List
QA Contact: Nag Pavan Chilakam
URL:
Whiteboard:
Depends On: 1273315
Blocks: 1311817
TreeView+ depends on / blocked
 
Reported: 2016-04-14 07:02 UTC by Pranith Kumar K
Modified: 2016-06-23 05:17 UTC (History)
10 users (show)

Fixed In Version: glusterfs-3.7.9-2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1273315
Environment:
Last Closed: 2016-06-23 05:17:27 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1240 0 normal SHIPPED_LIVE Red Hat Gluster Storage 3.1 Update 3 2016-06-23 08:51:28 UTC

Description Pranith Kumar K 2016-04-14 07:02:26 UTC
+++ This bug was initially created as a clone of Bug #1273315 +++

Description of problem:
Post readdirp we do lookup for each entry. We can avoid redundant lookup on
"." -> which is the $PWD it self and ".." -> parent.

--- Additional comment from Vijay Bellur on 2015-10-29 04:32:08 EDT ---

REVIEW: http://review.gluster.org/12374 (fuse: Avoid redundant lookup on "." and ".." credit: R. Gowdappa) posted (#3) for review on master by Raghavendra G (rgowdapp)

--- Additional comment from Vijay Bellur on 2015-10-29 04:32:35 EDT ---

COMMIT: http://review.gluster.org/12374 committed in master by Raghavendra G (rgowdapp) 
------
commit c1c5075df463fd298418bf31384b6d92f84d194b
Author: Susant Palai <spalai>
Date:   Fri Oct 16 09:57:22 2015 -0400

    fuse: Avoid redundant lookup on "." and ".."
    credit: R. Gowdappa
    
    Change-Id: I3bc1534e499f2eccd114db69a29c0b2ce82775db
    BUG: 1273315
    Reviewed-on: http://review.gluster.org/12374
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 5 Nag Pavan Chilakam 2016-05-09 08:39:39 UTC
Discussed with Dev. and found that there  is no clear  way of validating this bug as this is a code change with no direct functional impact.
Hence moving it to verified
However, following was what i did test:
tried to check the lookups using profiling and didn't find difference b/w fuse client versions of 3.7.9-1(before fix) and 3.7.9-3(after fix) (the server versions for both were common 3.7.9-3) However dev. mentioned that this may not be right test

Did a lot of IO and checked statedump before clearing client cache and after clearing client cache( searched for IO the hot-count in inode table ) didnt see much difference b/w the different client version

Comment 7 errata-xmlrpc 2016-06-23 05:17:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1240


Note You need to log in before you can comment on or make changes to this bug.