Bug 1327042 - Flash message displayed multiples times for invalid credentials
Summary: Flash message displayed multiples times for invalid credentials
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.6.0
Assignee: Martin Hradil
QA Contact: Niyaz Akhtar Ansari
URL:
Whiteboard: ui:error:flash_msg
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-14 07:19 UTC by Niyaz Akhtar Ansari
Modified: 2016-06-29 15:49 UTC (History)
6 users (show)

Fixed In Version: 5.6.0.5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-29 15:49:18 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:
nansari: automate_bug+


Attachments (Terms of Use)
error (55.14 KB, image/png)
2016-04-14 07:19 UTC, Niyaz Akhtar Ansari
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Niyaz Akhtar Ansari 2016-04-14 07:19:43 UTC
Created attachment 1147057 [details]
error

Description of problem:


Version-Release number of selected component (if applicable):
5.6.0.1-beta2.20160413141124_e25ac0e


How reproducible:
100%

Steps to Reproduce:
1.Navigate to login page 
2.Enter wrong User name or wrong Password and Click on login button
3.Repeat step 2 for multiple times 

Actual results:
Multiple flash messages displayed for invalid login when tried multiple times. see attached screenshot.

Expected results:
Only one flash message should be displayed for multiple invalid login.

Additional info:

Comment 2 Harpreet Kataria 2016-04-14 13:32:00 UTC
Martin,

When login button is pressed we should remove/replace the previous flash message in app/assets/javascripts/miq_application.js add_Flash js function.

~Harpreet

Comment 4 CFME Bot 2016-04-29 22:55:49 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1f0c710f5f9536ea9c7341efefad9130de7ee16c

commit 1f0c710f5f9536ea9c7341efefad9130de7ee16c
Author:     Martin Hradil <mhradil>
AuthorDate: Tue Apr 26 12:57:27 2016 +0000
Commit:     Martin Hradil <himdel>
CommitDate: Wed Apr 27 20:01:07 2016 +0000

    JS add_flash - add optional id, ensure uniqueness when given
    
    authentication failed message now gets an id of auth_failed, and removes the previous one if a new one with the same id is added
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1327042

 app/assets/javascripts/miq_application.js | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comment 5 Niyaz Akhtar Ansari 2016-05-04 05:03:47 UTC
Only one flash message displayed for multiple invalid login.

Verified in 5.6.0.5-beta2.4.20160503153816_1fb554f

Comment 8 errata-xmlrpc 2016-06-29 15:49:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348


Note You need to log in before you can comment on or make changes to this bug.