Description of problem:

e2image offers the capability to display progress data on the terminal while running. This feature is enabled using the -p flag. However, when directing an image to standard out, some of the progress data leaks into the image stream, corrupting the image.


Version-Release number of selected component (if applicable):

e2fsprogs-1.42.13-3.fc23.x86_64


How reproducible:

Completely


Steps to Reproduce:

### Follow along:
$ e2image -r /dev/sdb2 - | gzip --best >TestNoProgress.e2img.gz
e2image 1.42.13 (17-May-2015)
$ e2image -rp /dev/sdb2 - | gzip --best >TestWithProgress.e2img.gz
e2image 1.42.13 (17-May-2015)
Copied 16343 / 16343 blocks (100%) in 00:00:28 at 2.28 MB/s       s

   ### Decompressed images should be identical, but they are not.
$ zcat TestNoProgress.e2img.gz | sha256sum
d6551e9e979fb46b4f828cb1dccfc7babbf994187f5d869b155c316b2505cc6a  -
$ zcat TestWithProgress.e2img.gz | sha256sum
22fbf3f1e9a6daec5c52d6b16e17efadd75ecc8986e5adc3965e089b5b14d613  -

   ### With -p is 19 bytes longer.
$ zcat TestNoProgress.e2img.gz | wc -c
3699376128
$ zcat TestWithProgress.e2img.gz | wc -c
3699376147

   ### Comparing the last 4K (+/- 19 bytes) you can see the culprit.
$ zcat TestNoProgress.e2img.gz | tail -c 4096 | hexdump -Cv >TestNoProgress.e2img.footer
$ zcat TestWithProgress.e2img.gz | tail -c 4115 | hexdump -Cv >TestWithProgress.e2img.footer
$ diff TestNoProgress.e2img.footer TestWithProgress.e2img.footer
257c257,259
< 00001000
---
> 00001000  53 63 61 6e 6e 69 6e 67  20 69 6e 6f 64 65 73 2e  |Scanning inodes.|
> 00001010  2e 2e 0a                                          |...|
> 00001013


Actual results:

Generated image should be the same regardless of the -p flag. Generated image should never contain progress data.


Expected results:

When using the -p flag, progress data leaks into the image, corrupting it.


Additional info:

N/A