I'm really not sure where to assign this, but starting with pungi. The Atomic installer image recently started showing up in Rawhide composes. However, it fails to install. When booting the image, anaconda startup fails with a kickstart error: "ostree repos must use HTTP or HTTPS protocol" you can see a run here: https://openqa.fedoraproject.org/tests/13043 . https://openqa.fedoraproject.org/tests/13043/modules/_boot_to_anaconda/steps/8 shows the error, and you can watch a video of the run from the Logs & Assets tab.
This is affecting F24 as well. Proposing as a freeze exception issue since it's an install time bug and I know some people do care about the Atomic installer.
We landed some code intending to exclude ftp://, but everyone forgot that we *do* need to support file:// since it's used for the internal content.
exclude ftp where? mirrorlist/metalink will return ftp urls
They shouldn't for OSTree, since it's not supported.
Easy enough: diff --git a/pykickstart/commands/ostreesetup.py b/pykickstart/commands/ostreesetup.py index baa2325..c01f890 100644 --- a/pykickstart/commands/ostreesetup.py +++ b/pykickstart/commands/ostreesetup.py @@ -71,8 +71,8 @@ class F21_OSTreeSetup(KickstartCommand): if self.remote is None: self.remote = self.osname - if not self.url.startswith(("http:", "https:")): - raise KickstartValueError(formatErrorMsg(self.lineno, msg="ostree repos must use HTTP or HTTPS protocol.")) + if not self.url.startswith(("file:", "http:", "https:")): + raise KickstartValueError(formatErrorMsg(self.lineno, msg="ostree repos must use file, HTTP, or HTTPS protocol.")) return self diff --git a/tests/commands/ostreesetup.py b/tests/commands/ostreesetup.py index dac056f..b0b1533 100644 --- a/tests/commands/ostreesetup.py +++ b/tests/commands/ostreesetup.py @@ -29,6 +29,7 @@ class F21_TestCase(CommandTest): def runTest(self): # pass self.assert_parse("ostreesetup --osname=fedora-atomic --url=http://example.com/repo --ref=fedora-atomic/sometest/base/core") + self.assert_parse("ostreesetup --osname=local-atomic --url=file:///home/ostree --ref=fedora-atomic/sometest/base/core") cmdstr = "ostreesetup --osname=\"fedora-atomic\" --remote=\"fedora-atomic\" --url=\"http://example.com/repo\" --ref=\"fedora-atomic/sometest/base/core\" --nogpg" self.assert_parse(cmdstr, cmdstr + '\n')
+1 blocker
yeah, +1 blocker
+1 FE
dgilmore: masta: -10 reading comprehension ;)
still, that's three votes, counting the acceptedblockers as implicit acceptedFEs, setting acceptedFE.
pykickstart-2.25-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c38dadce8c
pykickstart-2.25-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Re-opening but dropping the F24 blocker stuff, because the fix wasn't sent to Rawhide yet; Rawhide Atomic installs still fail this way.
This is fixed in Rawhide now too, I believe.