Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-go-ini-ini/golang-github-go-ini-ini.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-go-ini-ini/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc20.src.rpm Description: Package ini provides INI file read and write functionality in Go Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13667486 $ rpmlint golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc20.src.rpm golang-github-go-ini-ini-devel-1.9.0-0.1.git193d1ec.fc20.noarch.rpm golang-github-go-ini-ini-unit-test-devel-1.9.0-0.1.git193d1ec.fc20.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
A few easy remarks: Version in changelog and version don't match. Also version 1.11.0 was released a bit ago
Updated. Thanks. I am packaging the project for cadvisor 0.22.2. This is the required commit based on cadvisor's Godeps.json file. I have not run comparison of this commit and 1.11.0 version yet. Once all its dependencies are packaged, I will take a look at 1.11.0.
Tests seem to be a bit unstable: + go test -compiler gc -ldflags '' github.com/go-ini/ini # github.com/go-ini/ini ../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:666: undefined: ShouldHaveLength ../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:673: undefined: ShouldHaveLength ../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:680: undefined: ShouldHaveLength ../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:687: undefined: ShouldHaveLength ../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:694: undefined: ShouldHaveLength ../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:701: undefined: ShouldHaveLength It failed for me in mock, and on copr, but succeeded on koji scratchbuilds :/
Building locally? Install latest rpms for golang-github-smartystreets-assertions [1] and golang-github-smartystreets-goconvey [2] [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=754528 [2] http://koji.fedoraproject.org/koji/buildinfo?buildID=754610 They are currently override in buildroot.
Aha, that explains it. Thanks
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1327497-golang-github-go-ini-ini/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-go-ini-ini-devel , golang-github-go-ini-ini-unit-test-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-go-ini-ini-devel-1.9.0-0.1.git193d1ec.fc25.noarch.rpm golang-github-go-ini-ini-unit-test-devel-1.9.0-0.1.git193d1ec.fc25.x86_64.rpm golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- golang-github-go-ini-ini-unit-test-devel (rpmlib, GLIBC filtered): golang(github.com/smartystreets/goconvey/convey) golang-github-go-ini-ini-devel golang-github-go-ini-ini-devel (rpmlib, GLIBC filtered): Provides -------- golang-github-go-ini-ini-unit-test-devel: golang-github-go-ini-ini-unit-test-devel golang-github-go-ini-ini-unit-test-devel(x86-64) golang-github-go-ini-ini-devel: golang(github.com/go-ini/ini) golang-github-go-ini-ini-devel Source checksums ---------------- https://github.com/go-ini/ini/archive/193d1ecb466bf97aae8b454a5cfc192941c64809/ini-193d1ec.tar.gz : CHECKSUM(SHA256) this package : add5babeb02483e371f768b45f2c156bf75b4a53dcbf6778f6eab766e45977c9 CHECKSUM(SHA256) upstream package : add5babeb02483e371f768b45f2c156bf75b4a53dcbf6778f6eab766e45977c9 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1327497 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package approved
*** Bug 1297549 has been marked as a duplicate of this bug. ***
Ugh, something I found out after approving this package: you need to link files from /usr/share/gocode/src/github.com/go-ini/ini/ to /usr/share/gocode/src/gopkg.in/ini.v1 or make them otherwise available.
Yeah, this is gopkg.in speciality. There are various ways how to write the prefix: - gopkg.in/ini.v1 - gopkg.in/v1/ini I usually extend the spec file once they are needed. Will update the spec file. This is no blocker for the review.
(In reply to Jan Chaloupka from comment #10) > Yeah, this is gopkg.in speciality. There are various ways how to write the > prefix: > - gopkg.in/ini.v1 > - gopkg.in/v1/ini > > I usually extend the spec file once they are needed. Will update the spec > file. This is no blocker for the review. Right, you should continue and request a package branch imho
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-ini-ini
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-38f800bb15
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-03bbbdeb12
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4d3bf84d8e
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f36d18e61
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f36d18e61
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4d3bf84d8e
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-38f800bb15
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-03bbbdeb12
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.