Spec URL: https://jjames.fedorapeople.org/nauty/nauty.spec SRPM URL: https://jjames.fedorapeople.org/nauty/nauty-2.6.4-1.fc25.src.rpm Fedora Account System Username: jjames Description: Nauty and Traces are programs for computing automorphism groups of graphs and digraphs. (At present, Traces does not accept digraphs.) They can also produce a canonical label. They are written in a portable subset of C, and run on a considerable number of different systems. There is a small suite of programs called gtools included in the package. For example, geng can generate non-isomorphic graphs very quickly. There are also generators for bipartite graphs, digraphs, and multigraphs, and programs for manipulating files of graphs in a compact format. The Fedora package was modeled on the Debian package in hopes that cross-distro compatibility might help consumers of this package.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ---> known bug in f-r - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ---> hint leads to outdated guidelines, ignoring ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Public domain". 95 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/reviews/1327784-nauty/licensecheck.txt ---> License is ASL-2.0 and Public Domain, please fix during import [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). ---> except for naming the sub-packages, but that is cosmetic [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 542720 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libnauty , nauty-debuginfo ---> that fine, debuginfo is autogenerated, libnauty is fine standalone [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint ---> know bug in f-r [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.17 starting (python version = 3.5.1)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.17 INFO: Mock Version: 1.2.17 Finish: chroot init INFO: installing package(s): /home/besser82/shared/fedora/reviews/1327784-nauty/results/nauty-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/libnauty-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/libnauty-devel-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/nauty-debuginfo-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/nauty-debuginfo-2.6.4-1.fc25.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 25 --disableplugin=local --setopt=deltarpm=false install /home/besser82/shared/fedora/reviews/1327784-nauty/results/nauty-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/libnauty-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/libnauty-devel-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/nauty-debuginfo-2.6.4-1.fc25.x86_64.rpm /home/besser82/shared/fedora/reviews/1327784-nauty/results/nauty-debuginfo-2.6.4-1.fc25.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: nauty-2.6.4-1.fc25.x86_64.rpm libnauty-2.6.4-1.fc25.x86_64.rpm libnauty-devel-2.6.4-1.fc25.x86_64.rpm nauty-debuginfo-2.6.4-1.fc25.x86_64.rpm nauty-2.6.4-1.fc25.src.rpm nauty.x86_64: W: spelling-error Summary(en_US) automorphism -> metamorphism nauty.x86_64: W: spelling-error %description -l en_US automorphism -> metamorphism nauty.x86_64: W: spelling-error %description -l en_US gtools -> tools, stools, g tools nauty.x86_64: W: spelling-error %description -l en_US geng -> gen, gene, gens nauty.x86_64: W: spelling-error %description -l en_US multigraphs -> lithographs libnauty.x86_64: W: spelling-error Summary(en_US) automorphism -> metamorphism libnauty.x86_64: W: spelling-error %description -l en_US Nauty -> Nasty, Natty, Naughty libnauty.x86_64: W: spelling-error %description -l en_US automorphism -> metamorphism libnauty.x86_64: W: spelling-error %description -l en_US nauty -> nasty, natty, naughty libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyS1.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyA1.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyL0.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyS0.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyW0.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyW1.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnautyL1.so.2.6.4 exit.5 libnauty.x86_64: W: shared-lib-calls-exit /usr/lib64/libnauty.so.2.6.4 exit.5 libnauty-devel.x86_64: W: only-non-binary-in-usr-lib nauty.src: W: spelling-error Summary(en_US) automorphism -> metamorphism nauty.src: W: spelling-error %description -l en_US automorphism -> metamorphism nauty.src: W: spelling-error %description -l en_US gtools -> tools, stools, g tools nauty.src: W: spelling-error %description -l en_US geng -> gen, gene, gens nauty.src: W: spelling-error %description -l en_US multigraphs -> lithographs 5 packages and 0 specfiles checked; 0 errors, 23 warnings. Requires -------- nauty-debuginfo (rpmlib, GLIBC filtered): libnauty-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libnauty(x86-64) libnauty.so.2()(64bit) libnautyA1.so.2()(64bit) libnautyL0.so.2()(64bit) libnautyL1.so.2()(64bit) libnautyS0.so.2()(64bit) libnautyS1.so.2()(64bit) libnautyW0.so.2()(64bit) libnautyW1.so.2()(64bit) nauty (rpmlib, GLIBC filtered): coreutils libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libnauty(x86-64) libnauty.so.2()(64bit) libnauty.so.2(LIBNAUTY_2.5)(64bit) libnautyL1.so.2()(64bit) libnautyL1.so.2(LIBNAUTYL1_2.5)(64bit) libnautyW1.so.2()(64bit) libnautyW1.so.2(LIBNAUTYW1_2.5)(64bit) libpthread.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) libnauty (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- nauty-debuginfo: nauty-debuginfo nauty-debuginfo(x86-64) libnauty-devel: libnauty-devel libnauty-devel(x86-64) pkgconfig(nauty) nauty: nauty nauty(x86-64) libnauty: libnauty libnauty(x86-64) libnauty.so.2()(64bit) libnauty.so.2(LIBNAUTY_2.5)(64bit) libnautyA1.so.2()(64bit) libnautyA1.so.2(LIBNAUTYA1_2.5)(64bit) libnautyL0.so.2()(64bit) libnautyL0.so.2(LIBNAUTYL0_2.5)(64bit) libnautyL1.so.2()(64bit) libnautyL1.so.2(LIBNAUTYL1_2.5)(64bit) libnautyS0.so.2()(64bit) libnautyS0.so.2(LIBNAUTYS0_2.5)(64bit) libnautyS1.so.2()(64bit) libnautyS1.so.2(LIBNAUTYS1_2.5)(64bit) libnautyW0.so.2()(64bit) libnautyW0.so.2(LIBNAUTYW0_2.5)(64bit) libnautyW1.so.2()(64bit) libnautyW1.so.2(LIBNAUTYW1_2.5)(64bit) Source checksums ---------------- http://pallini.di.uniroma1.it/nauty26r4.tar.gz : CHECKSUM(SHA256) this package : a1c8326cbe955a967a0f1747cc2ae04569cced1ac7cf92c9309c843f5c2c2a98 CHECKSUM(SHA256) upstream package : a1c8326cbe955a967a0f1747cc2ae04569cced1ac7cf92c9309c843f5c2c2a98 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1327784 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 ===== Solution ===== Package approved! Have fun.
Thank you very much for the speedy review, Björn. I will fix the license field on import as requested.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nauty
nauty-2.6.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1c5728a7a8
nauty-2.6.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1c5728a7a8
nauty-2.6.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.