Bug 1327792 - Azure provision fails if Security Group left as "Not Selected"
Summary: Azure provision fails if Security Group left as "Not Selected"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Provisioning
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.6.0
Assignee: Bronagh Sorota
QA Contact: Jeff Teehan
URL:
Whiteboard: provisioning:ui:azure
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-15 23:42 UTC by Jeff Teehan
Modified: 2016-06-29 15:50 UTC (History)
4 users (show)

Fixed In Version: 5.6.0.6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-29 15:50:15 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Jeff Teehan 2016-04-15 23:42:52 UTC
Description of problem:


Version-Release number of selected component (if applicable):
5.6.0.1 Beta 2

How reproducible:
Customer (https://github.com/ManageIQ/manageiq/issues/7900) and QE Infrastructure

Steps to Reproduce:
1.  Provision Azure VM from custom image.
2.  Fill out all required fields.
3.  Leave Security Group to "Not Selected"
4.  Commit

Actual results:
The UI locks up.  Error in evm.log of "[----] E, [2016-04-15T19:14:30.287573 #12188:12c5988] ERROR -- : Q-task_id([miq_provision_415000000000001]) /var/www/miq/vmdb/app/models/manageiq/providers/azure/cloud_manager/provision/cloning.rb:107:in `block in create_nic'

or 

(security_group is nil)

Expected results:
According to the ARM spec, a new Security Group with the same name as the Virtual Machine should be created and assigned to the VM if an existing Security Group is not selected.

Additional info:

Check last build - Nightly 2016/04/04 - Failed

https://github.com/ManageIQ/manageiq/issues/7900

Virtual Private Cloud cfmeqe (10.1.0.0/16)
Cloud Subnet default (10.1.0.0/24)
Security Groups
Resource Groups cfmeqe

Comment 2 Jeff Teehan 2016-04-16 00:08:17 UTC
This is not a Required field as far as selecting an existing Network Security Group (NSG) is concerned in Azure.  The default Azure RM deployment model in the Portal will create an NSG with the same name as VMName in the selected subnet, or an existing one can be selected.  Overriding the NSG is an option if a "standard" NSG has been created for the SubNet.

Any fix will require the creation of an NSG with the same name as the VM if one is not selected.

Comment 3 Greg McCullough 2016-04-27 13:43:32 UTC
PR https://github.com/ManageIQ/manageiq/pull/8092

Comment 4 CFME Bot 2016-05-04 06:10:38 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d3ea9abc07f8dde267d59248f6bd6138b0f5bb7b

commit d3ea9abc07f8dde267d59248f6bd6138b0f5bb7b
Author:     Bronagh Sorota <bsorota>
AuthorDate: Fri Apr 22 10:02:58 2016 -0400
Commit:     Bronagh Sorota <bsorota>
CommitDate: Tue May 3 15:05:21 2016 -0400

    spec tests to test provisioning if a security
    group is set or not.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1327792

 .../azure/cloud_manager/provision/cloning.rb       | 46 ++++++++++++----------
 .../azure/cloud_manager/provision_spec.rb          | 23 +++++++++--
 2 files changed, 44 insertions(+), 25 deletions(-)

Comment 5 Bronagh Sorota 2016-05-06 13:32:05 UTC
https://github.com/ManageIQ/manageiq/pull/8092/commits/ca2633cc73cbdf0cfaaeb41498923cfca0cec513

commit ca2633cc73cbdf0cfaaeb41498923cfca0cec513
Author: Romain Bertrand <romain>
Date:   Tue Apr 19 17:02:49 2016 +0200

    fix arm provisioning if no security_group is selected

app/models/manageiq/providers/azure/cloud_manager/provision/cloning.rb

Comment 6 Jeff Teehan 2016-05-13 20:13:45 UTC
Cool.  Should still have setting for adding new NSG, but that's a different matter.  Moving to verified using 5.6.0.6 on https://10.16.7.169

Comment 9 errata-xmlrpc 2016-06-29 15:50:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348


Note You need to log in before you can comment on or make changes to this bug.