Spec URL: https://chandankumar.fedorapeople.org/python-k8sclient.spec SRPM URL: https://chandankumar.fedorapeople.org/python-k8sclient-0.1.0-1.fc23.src.rpm Description: This is Kubernetes API python client code. This code is generated by swagger-codegen. Kubernetes provide swagger-spec to generate client code for different versions. Fedora Account System Username: chandankumar Successful Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=13695941
1) URL can be changed to https://github.com/openstack/python-k8sclient or https://pypi.python.org/pypi/python-k8sclient 2) Here another issue is pypi_name macro contains "python" which made all the reference of it problematic. E.g. the doc package become python-python-k8sclient-doc. Better avoid using pypi_macro wherever needed. 3) In current submitted version of srpm, rpmlint complains about python-python-k8sclient-doc.noarch: W: summary-not-capitalized C python-k8sclient documentation. 4) for python2 %files section, use %license macro for LICENSE file Rest looks fine. Please provide updated package fixing above.
Hello Parag, Comments are addressed and updated in the spec file. Here is the updated spec file : https://chandankumar.fedorapeople.org/python-k8sclient.spec SRPM Link : https://chandankumar.fedorapeople.org/python-k8sclient-0.1.0-2.fc23.src.rpm Successful Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=13696340 Thanks, Chandan Kumar
I can still see the pypi_name macro usage issue for -doc package and python_provide macro.
oops I overlooked, -doc seems fixed but python_provide macro not.
Thanks Parag for the review. Here is the updated SPEC file: https://chandankumar.fedorapeople.org/python-k8sclient.spec SRPM Link : https://chandankumar.fedorapeople.org/python-k8sclient-0.1.0-3.fc23.src.rpm Thanks, Chandan Kumar
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Suggestions: 1) While doing official review, I found LICENSE file is missing for -doc subpackage, please add it while importing package. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 119 files have unknown license. Detailed output of licensecheck in /home/parag/1327939-python-k8sclient/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-k8sclient , python3-k8sclient , python-k8sclient-doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. Well we ignored it but I think we can fix this later on. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-k8sclient-0.1.0-3.fc25.noarch.rpm python3-k8sclient-0.1.0-3.fc25.noarch.rpm python-k8sclient-doc-0.1.0-3.fc25.noarch.rpm python-k8sclient-0.1.0-3.fc25.src.rpm python2-k8sclient.noarch: W: spelling-error %description -l en_US codegen -> code gen, code-gen, encode python2-k8sclient.noarch: W: spelling-error %description -l en_US Kubernetes -> Rubbernecks python3-k8sclient.noarch: W: spelling-error %description -l en_US codegen -> code gen, code-gen, encode python3-k8sclient.noarch: W: spelling-error %description -l en_US Kubernetes -> Rubbernecks python-k8sclient.src: W: spelling-error %description -l en_US codegen -> code gen, code-gen, encode python-k8sclient.src: W: spelling-error %description -l en_US Kubernetes -> Rubbernecks 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- python2-k8sclient.noarch: W: spelling-error %description -l en_US codegen -> code gen, code-gen, encode python2-k8sclient.noarch: W: spelling-error %description -l en_US Kubernetes -> Rubbernecks python3-k8sclient.noarch: W: spelling-error %description -l en_US codegen -> code gen, code-gen, encode python3-k8sclient.noarch: W: spelling-error %description -l en_US Kubernetes -> Rubbernecks 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python2-k8sclient (rpmlib, GLIBC filtered): python(abi) python-dateutil python-pbr python-six python-urllib3 python-k8sclient-doc (rpmlib, GLIBC filtered): python3-k8sclient (rpmlib, GLIBC filtered): python(abi) python3-dateutil python3-pbr python3-six python3-urllib3 Provides -------- python2-k8sclient: python-k8sclient python2-k8sclient python-k8sclient-doc: python-k8sclient-doc python3-k8sclient: python3-k8sclient Source checksums ---------------- https://pypi.python.org/packages/source/p/python-k8sclient/python-k8sclient-0.1.0.tar.gz : CHECKSUM(SHA256) this package : 88613894dbda82d4f59f1c9f0fd18bd42340c53cf2025acbc98e1e128dd5a2fd CHECKSUM(SHA256) upstream package : 88613894dbda82d4f59f1c9f0fd18bd42340c53cf2025acbc98e1e128dd5a2fd Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 APPROVED.
Do you have github repo with rpm-master branch ready to import to openstack-packages ?
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-k8sclient
python-k8sclient-0.1.0-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d8215bf0d0
python-k8sclient-0.1.0-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d761d5b710
python-k8sclient-0.1.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d8215bf0d0
python-k8sclient-0.1.0-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d761d5b710
python-k8sclient-0.1.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-k8sclient-0.1.0-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days