Description of problem: I'm reviewing the package in bug report https://bugzilla.redhat.com/show_bug.cgi?id=1326504. The SRPM is hosted on GitHub and a query is needed at the end of the URL to ensure that the file is downloaded properly: https://github.com/SamStudio8/htslib-pkg/blob/master/htslib-1.3-1.fc23.src.rpm?raw=true fedora-review appears to ignore that string, and so the review fails because it downloads the GitHub error page instead and that is not an SRPM. Version-Release number of selected component (if applicable): fedora-review-0.6.0-2.fc23.noarch How reproducible: Every time Steps to Reproduce: 1. start fedora-review with an upstream URL including a query string 2. 3. Actual results: fedora-review fails to download the SRPM and stops with an error Expected results: fedora-review includes the URL query string and succeeds in downloading the SRPM Additional info:
hm... To be honest, I don't remember all the reasoning behind the fact that the query string is stripped from the URL. That said, it's not an oversight but a deliberated decision which is documented in the manpage's URL LIMITATIONS section. The way to cope with situations like this is to download the srpm manually and run fedora-review on that e. g., fedora-review -rn <srpm-file>. Since this is the intended and documented behaviour I'm closing this as not-a-bug.