Hide Forgot
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mizdebsk/newpkg/mnemonicsetter.git/plain/mnemonicsetter.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mizdebsk/newpkg/fedora-rawhide-x86_64/00178907-mnemonicsetter/mnemonicsetter-0.4-1.fc25.src.rpm Description: Java library, which automatically assigns mnemonics to menu items and toolbar elements. Fedora Account System Username: mizdebsk
with fedora-review -b 1328374 --plugins Java -m fedora-rawhide-i386 + cd /builddir/build/BUILD + rm -rf mnemonicsetter-mnemonicsetter_0.4 + /usr/bin/gzip -dc /builddir/build/SOURCES/mnemonicsetter_0.4.tar.gz + /usr/bin/tar -xof - + STATUS=0 + '[' 0 -ne 0 ']' + cd mnemonicsetter-mnemonicsetter_0.4 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + echo 'Patch #0 (mnemonicsetter-remove-bintray-plugin.patch):' + /usr/bin/patch -p0 --fuzz=0 Patch #0 (mnemonicsetter-remove-bintray-plugin.patch): patching file build.gradle + echo 'rootProject.name="mnemonicsetter"' + exit 0 Esecuzione(%build) in corso: /bin/sh -e /var/tmp/rpm-tmp.L8QWns + umask 022 + cd /builddir/build/BUILD + cd mnemonicsetter-mnemonicsetter_0.4 + /usr/bin/python3 /usr/share/java-utils/mvn_build.py --gradle Executing: gradle-local --no-daemon --offline build xmvnInstall ['gradle-local', '--no-daemon', '--offline', 'build', 'xmvnInstall'] :compileJavawarning: [options] bootstrap class path not set in conjunction with -source 1.7 1 warning :processResources UP-TO-DATE :classes :jar :assemble :compileTestJavawarning: [options] bootstrap class path not set in conjunction with -source 1.7 1 warning :processTestResources UP-TO-DATE :testClasses :test FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':test'. > Cannot locate JAR for module 'guava-jdk5' in distribution directory '/usr/share/gradle'. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED I proceed with a manual review ...
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation IGNORE ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 1 files have unknown license. Detailed output of licensecheck in /home/gil/1328374-mnemonicsetter/srpm/review- mnemonicsetter/licensecheck.txt [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mnemonicsetter-0.4-1.fc25.noarch.rpm mnemonicsetter-0.4-1.fc25.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- mnemonicsetter (rpmlib, GLIBC filtered): java-headless javapackages-tools Provides -------- mnemonicsetter: mnemonicsetter mvn(org.dpolivaev.mnemonicsetter:mnemonicsetter) Source checksums ---------------- https://github.com/dpolivaev/mnemonicsetter/archive/mnemonicsetter_0.4.tar.gz : CHECKSUM(SHA256) this package : 51add35bb6db80b4e00de862bf15ecc3afa14b8385442c951a2d8d495c15206c CHECKSUM(SHA256) upstream package : 51add35bb6db80b4e00de862bf15ecc3afa14b8385442c951a2d8d495c15206c Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -vpn mnemonicsetter --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Approved
Thank you.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mnemonicsetter