Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mizdebsk/newpkg/dain-snappy.git/plain/dain-snappy.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mizdebsk/newpkg/fedora-rawhide-x86_64/00178992-dain-snappy/dain-snappy-0.4-1.fc25.src.rpm Description: This is a rewrite (port) of Snappy writen in pure Java. This compression code produces a byte-for-byte exact copy of the output created by the original C++ code, and extremely fast. Fedora Account System Username: mizdebsk
can you add this to the spec file? # use system coreutils rm testdata/sum %pom_remove_plugin :maven-jar-plugin # Generate OSGi manifest file %pom_xpath_set "pom:packaging" bundle %pom_add_plugin org.apache.felix:maven-bundle-plugin:2.5.4 . ' <extensions>true</extensions> <configuration> <instructions> <Bundle-Name>Snappy</Bundle-Name> <Bundle-SymbolicName>${project.groupId}</Bundle-SymbolicName> <Bundle-Version>${project.version}.0</Bundle-Version> <Export-Package>org.iq80.snappy.*</Export-Package> <Main-Class>org.iq80.snappy.Main</Main-Class> <Import-Package> !org.apache.hadoop.*, *;resolution:=optional </Import-Package> </instructions> </configuration> <executions> <execution> <id>bundle-manifest</id> <phase>process-classes</phase> <goals> <goal>manifest</goal> </goals> </execution> </executions>'
these tasks are unnecessary %pom_remove_plugin :maven-source-plugin %pom_remove_plugin :maven-javadoc-plugin %pom_remove_plugin :maven-release-plugin
can import this package also for F23 and F24?
i used for my package iq80-snappy name
(In reply to gil cattaneo from comment #1) > # use system coreutils > rm testdata/sum This is only a test resource, it's not executed during build. > %pom_remove_plugin :maven-jar-plugin > # Generate OSGi manifest file > [...] Why? If there is some package requiring OSGi metadata then I can always add it later. (In reply to gil cattaneo from comment #2) > these tasks are unnecessary > %pom_remove_plugin :maven-source-plugin > %pom_remove_plugin :maven-javadoc-plugin > %pom_remove_plugin :maven-release-plugin I've already removed maven-javadoc-plugin invocation due to missing doclet (doclava). maven-release-plugin is not executed. I don't see any reason to remove maven-source-plugin. (In reply to gil cattaneo from comment #3) > can import this package also for F23 and F24? Sure. (In reply to gil cattaneo from comment #4) > i used for my package iq80-snappy name I thought about that too, but http://iq80.org/snappy redirects to Github, where the package is prefixed with "dain".
(In reply to Mikolaj Izdebski from comment #5) > (In reply to gil cattaneo from comment #1) > > # use system coreutils > > rm testdata/sum > > This is only a test resource, it's not executed during build. > > > %pom_remove_plugin :maven-jar-plugin > > # Generate OSGi manifest file > > [...] > > Why? If there is some package requiring OSGi metadata then I can always add > it later. activemq (leveldb-store) and others ... but now I've forgotten what ... > (In reply to gil cattaneo from comment #2) > > these tasks are unnecessary > > %pom_remove_plugin :maven-source-plugin > > %pom_remove_plugin :maven-javadoc-plugin > > %pom_remove_plugin :maven-release-plugin > > I've already removed maven-javadoc-plugin invocation due to missing doclet > (doclava). maven-release-plugin is not executed. I don't see any reason to > remove maven-source-plugin. thanks > (In reply to gil cattaneo from comment #3) > > can import this package also for F23 and F24? > > Sure. thanks > (In reply to gil cattaneo from comment #4) > > i used for my package iq80-snappy name > > I thought about that too, but http://iq80.org/snappy redirects to Github, > where the package is prefixed with "dain". nevermind, thanks
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSD (3 clause)", "Unknown or generated". 6 files have unknown license. Detailed output of licensecheck in /home/gil/1328508-dain-snappy/review-dain-snappy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dain- snappy-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dain-snappy-0.4-1.fc25.noarch.rpm dain-snappy-javadoc-0.4-1.fc25.noarch.rpm dain-snappy-0.4-1.fc25.src.rpm dain-snappy.noarch: W: spelling-error %description -l en_US writen -> write, written, writes dain-snappy.src: W: spelling-error %description -l en_US writen -> write, written, writes 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory dain-snappy.noarch: W: spelling-error %description -l en_US writen -> write, written, writes 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- dain-snappy-javadoc (rpmlib, GLIBC filtered): javapackages-tools dain-snappy (rpmlib, GLIBC filtered): java-headless javapackages-tools Provides -------- dain-snappy-javadoc: dain-snappy-javadoc dain-snappy: dain-snappy mvn(org.iq80.snappy:snappy) mvn(org.iq80.snappy:snappy:pom:) Source checksums ---------------- https://github.com/dain/snappy/archive/e02f7c887d666afbdd11763f3a6ba22e68f53f15/dain-snappy-e02f7c8.tar.gz : CHECKSUM(SHA256) this package : cbeff4a183b8e2a3b273176cc43314b25c358b0ef3278724dba19977df178f75 CHECKSUM(SHA256) upstream package : cbeff4a183b8e2a3b273176cc43314b25c358b0ef3278724dba19977df178f75 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -vpn dain-snappy --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Approved
Thanks again for quick review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dain-snappy
dain-snappy-0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ebcb183853
dain-snappy-0.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-226fd6ddf7
Package built for rawhide. F23/F24 updates submitted.
dain-snappy-0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ebcb183853
dain-snappy-0.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-226fd6ddf7
dain-snappy-0.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
dain-snappy-0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.