Bug 1328764 - Setup does not dump keys that are initialized to None
Summary: Setup does not dump keys that are initialized to None
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: otopi
Classification: oVirt
Component: Core
Version: master
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.2.0
: 1.7.0
Assignee: Yedidyah Bar David
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-20 09:02 UTC by David Caro
Modified: 2019-04-28 13:55 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-12 12:55:54 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: planning_ack+
rule-engine: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 79640 0 master MERGED core: Dump env keys when added even if None 2017-07-20 13:17:50 UTC

Description David Caro 2016-04-20 09:02:48 UTC 
Description of problem:
When running the setup with an answerfile, otopi skips dumping any env keys that are initialized to 'None', and that will help a lot on debugging and discovering new keys

Version-Release number of selected component (if applicable):
otopi-1.5.0-0.0.master.20160403070351.gitfa92bb0.el7.noarch

How reproducible:
Just run the engine setup with an answerfile

Steps to Reproduce:
1.
2.
3.

Actual results:
You will not see some env keys, like OVESETUP_DWH_CORE/enable, that are initialized to 'None'

Expected results:
You see all the possible keys and their values

Additional info:
Comment 2 Pavel Stehlik 2017-08-30 12:03:59 UTC 
CodeChange - thus nothing for QE.
Comment 3 Yedidyah Bar David 2017-12-13 12:32:57 UTC 
An example of how to verify:

1. Run engine-setup interactively, without an answer file
2. grep -C 3 OVESETUP_DWH_CORE/enable $PATH_TO_SETUP_LOG

In otopi-1.6 (oVirt 4.1), the first occurrence will be:

2017-05-18 15:15:58 DEBUG otopi.plugins.otopi.dialog.human dialog.__logString:204 DIALOG:SEND                 Configure Data Warehouse on this host (Yes, No) [Yes]: 
2017-05-18 15:15:59 DEBUG otopi.context context.dumpEnvironment:760 ENVIRONMENT DUMP - BEGIN
2017-05-18 15:15:59 DEBUG otopi.context context.dumpEnvironment:770 ENV OVESETUP_DWH_CONFIG/dwhServiceStopNeeded=bool:'True'
2017-05-18 15:15:59 DEBUG otopi.context context.dumpEnvironment:770 ENV OVESETUP_DWH_CORE/enable=bool:'True'
2017-05-18 15:15:59 DEBUG otopi.context context.dumpEnvironment:774 ENVIRONMENT DUMP - END

In 1.7 (4.2), the first will be:

2017-12-12 09:19:37,719+0200 DEBUG otopi.context context._executeMethod:128 Stage init METHOD otopi.plugins.ovirt_engine_common.ovirt_engine_dwh.core.misc.Plugin._init
2017-12-12 09:19:37,719+0200 DEBUG otopi.context context.dumpEnvironment:821 ENVIRONMENT DUMP - BEGIN
2017-12-12 09:19:37,720+0200 DEBUG otopi.context context.dumpEnvironment:831 ENV OVESETUP_DWH_CORE/enable=NoneType:'None'
2017-12-12 09:19:37,720+0200 DEBUG otopi.context context.dumpEnvironment:831 ENV OVESETUP_ENGINE_CORE/enable=NoneType:'None'
2017-12-12 09:19:37,720+0200 DEBUG otopi.context context.dumpEnvironment:835 ENVIRONMENT DUMP - END
Note You need to log in before you can comment on or make changes to this bug.