Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1328860

Summary: [dwh] engine-cleanup on separate dwh machine does not reset dwh_history_timekeeping
Product: [oVirt] ovirt-engine-dwh Reporter: Yedidyah Bar David <didi>
Component: SetupAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.6.0CC: bugs, jbelka, sbonazzo
Target Milestone: ovirt-4.0.0-betaFlags: rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
sbonazzo: devel_ack+
rule-engine: testing_ack+
Target Release: 4.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 07:40:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2016-04-20 12:39:09 UTC
Description of problem:

$Subject.

Version-Release number of selected component (if applicable):

current master. Probably much earlier.

How reproducible:

Always I think

Steps to Reproduce:
1. setup engine on machine A
2. setup dwh on machine B
3. engine-cleanup on machine B
4. engine-setup again on machine B with same engine

Actual results:

step 4 prompts:

          An existing DWH is configured to work with this engine.
          Its hostname is didi-f19-dwh.eng.lab.tlv.redhat.com.
          A positive answer to the following question will cause the existing DWH to be permanently disconnected from the engine.
          A negative answer will stop Setup.
          Do you want to permanently disconnect this DWH from the engine? (Yes, No) [No]:

Running on engine db:

engine=# select * from dwh_history_timekeeping ;
      var_name       |              var_value               |         var_datetime
---------------------+--------------------------------------+-------------------------------
 dwhHostname         | didi-f19-dwh.eng.lab.tlv.redhat.com  |
 dwhUuid             | 45dc9a51-3545-4941-ad3d-7fb47af91b32 |

Expected results:

Should not prompt.

dwhHostname and dwhUuid should be empty.

Additional info:

dwh:packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py creates a connection, but never commits it.

It should probably behave similarly to the engine, in:

engine:packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py

we add a transactionelement DBTransaction which commits.

We also have this in dwh, in

packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py

which is not called in cleanup.

Probably left behind in:

https://gerrit.ovirt.org/39545

Comment 1 Sandro Bonazzola 2016-05-02 09:49:19 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 2 Jiri Belka 2016-07-01 15:27:52 UTC
ok, ovirt-engine-dwh-setup-4.0.0-2.el7ev.noarch

checked DB and dashboard after last step

Comment 3 Sandro Bonazzola 2016-07-05 07:40:13 UTC
oVirt 4.0.0 has been released, closing current release.