Description of problem:

$Subject.

Version-Release number of selected component (if applicable):

current master. Probably much earlier.

How reproducible:

Always I think

Steps to Reproduce:
1. setup engine on machine A
2. setup dwh on machine B
3. engine-cleanup on machine B
4. engine-setup again on machine B with same engine

Actual results:

step 4 prompts:

          An existing DWH is configured to work with this engine.
          Its hostname is didi-f19-dwh.eng.lab.tlv.redhat.com.
          A positive answer to the following question will cause the existing DWH to be permanently disconnected from the engine.
          A negative answer will stop Setup.
          Do you want to permanently disconnect this DWH from the engine? (Yes, No) [No]:

Running on engine db:

engine=# select * from dwh_history_timekeeping ;
      var_name       |              var_value               |         var_datetime
---------------------+--------------------------------------+-------------------------------
 dwhHostname         | didi-f19-dwh.eng.lab.tlv.redhat.com  |
 dwhUuid             | 45dc9a51-3545-4941-ad3d-7fb47af91b32 |

Expected results:

Should not prompt.

dwhHostname and dwhUuid should be empty.

Additional info:

dwh:packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py creates a connection, but never commits it.

It should probably behave similarly to the engine, in:

engine:packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py

we add a transactionelement DBTransaction which commits.

We also have this in dwh, in

packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py

which is not called in cleanup.

Probably left behind in:

https://gerrit.ovirt.org/39545