Bug 1328993 - Install is setting --insecure-registry incorrectly for Docker in 3.2.0.17, ignoring networks settings in inventory
Summary: Install is setting --insecure-registry incorrectly for Docker in 3.2.0.17, ig...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.2.0
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
: ---
Assignee: Devan Goodwin
QA Contact: Mike Fiedler
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-20 20:23 UTC by Mike Fiedler
Modified: 2016-05-12 16:40 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-12 16:40:43 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1065 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise atomic-openshift-utils bug fix update 2016-05-12 20:32:56 UTC

Description Mike Fiedler 2016-04-20 20:23:17 UTC
Description of problem:

1. In 3.2.0.15, given the following settings in the inventory for the byo playbook:

openshift_master_portal_net=172.24.0.0/14
osm_cluster_network_cidr=172.20.0.0/14

The install would set /etc/sysconfig/docker OPTIONS to:

OPTIONS=' --selinux-enabled --insecure-registry=172.24.0.0/14'

This is correct.


2. In 3.2.0.17, given the same settings in the inventory, it sets OPTIONS to

OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16'

which results in an unusable registry.  The registry IP is outside of the insecure range.


Version-Release number of selected component (if applicable): 3.2.0.17


How reproducible: Always


Steps to Reproduce:
1. Install using an inventory with the following settings:


openshift_master_portal_net=172.24.0.0/14
osm_cluster_network_cidr=172.20.0.0/14

2. After the install check /etc/sysconfig/docker


Actual results:

OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16'


Expected results:

Honor the network mask/CIDR settings in the inventory.

OPTIONS=' --selinux-enabled --insecure-registry=172.24.0.0/14'

Comment 2 Mike Fiedler 2016-04-21 01:58:21 UTC
Additional info:  all installs I've personally seen this on are AWS

Comment 3 Ma xiaoqiang 2016-04-21 03:01:18 UTC
openshift-ansible-3.0.80-1 works fine , openshift-ansible-3.0.82-1 can not set --insecure-registry incorrectly in docker. it has nothing with openshift and inventories. thx

Comment 4 Mike Fiedler 2016-04-21 11:40:06 UTC
@xiaoqiang

I ran two tests with identical playbooks.   The only difference was the openshift-ansible commit level.

Test 1:  openshift-ansible commit level is 55e36e376858d023203f4a3d7884c830109bc122.  No changes from April 20.

Result:  OPTIONS=' --selinux-enabled --insecure-registry=172.24.0.0/14 '


Test 2:  openshift-ansible commit level is fd2eef29ab0b34ee55920b25226d570bd0501ed0 (3 new commits on April 20)

Result:  OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16 '

Comment 5 Mike Fiedler 2016-04-21 11:40:45 UTC
comment 4 : should be "identical inventories".  Playbook is openshift-ansible/playbooks/byo/config.yml

Comment 6 Devan Goodwin 2016-04-21 12:23:03 UTC
Looks like it was caused by this PR https://github.com/openshift/openshift-ansible/pull/1588/files where the portal_net property was renamed to openshift_portal_net, and may not be properly backward compatible. Will test, verify and fix shortly today.

Comment 7 Devan Goodwin 2016-04-21 13:35:04 UTC
Fixed in: https://github.com/openshift/openshift-ansible/pull/1783

Just a complication from the move to another role and a couple missed uses.

Comment 8 Troy Dawson 2016-04-22 20:34:35 UTC
Should be fixed in openshift-ansible-3.0.84-1.git.0.04b5245.el7

Comment 9 Mike Fiedler 2016-04-25 23:40:48 UTC
Verified by running the same inventory which failed initially

Comment 11 errata-xmlrpc 2016-05-12 16:40:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1065


Note You need to log in before you can comment on or make changes to this bug.