Spec URL: https://gil.fedorapeople.org/cassandra/primitive.spec SRPM URL: https://gil.fedorapeople.org/cassandra/primitive-1.2.2-1.fc23.src.rpm Description: Primitive provides utility methods for functionality related to primitive types. Currently, the only functionality is the ability to sort primitive arrays using custom comparators. Packaging as a build-requirement for cassandra. Fedora Account System Username: trepik
Please, use: https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch
can you take these for me? https://bugzilla.redhat.com/show_bug.cgi?id=1328062 https://bugzilla.redhat.com/show_bug.cgi?id=1328063
Spec URL: https://trepik.fedorapeople.org/primitive-java/v1/primitive.spec SRPM URL: https://trepik.fedorapeople.org/primitive-java/v1/primitive-1.2.2-2.fc23.src.rpm * Thu Apr 21 2016 Tomas Repik <trepik> - 1.2.2-2 - new patch for license headers
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL". Detailed output of licensecheck in /home/gil/1329201-primitive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dain- snappy-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: primitive-1.2.2-2.fc25.noarch.rpm primitive-javadoc-1.2.2-2.fc25.noarch.rpm primitive-1.2.2-2.fc25.src.rpm primitive.noarch: W: name-repeated-in-summary C primitive primitive.noarch: W: spelling-error %description -l en_US comparators -> compactors, commemorators, cooperators primitive.src: W: name-repeated-in-summary C primitive primitive.src: W: spelling-error %description -l en_US comparators -> compactors, commemorators, cooperators 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory primitive.noarch: W: name-repeated-in-summary C primitive primitive.noarch: W: spelling-error %description -l en_US comparators -> compactors, commemorators, cooperators 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- primitive-javadoc (rpmlib, GLIBC filtered): javapackages-tools primitive (rpmlib, GLIBC filtered): java-headless javapackages-tools Provides -------- primitive-javadoc: primitive-javadoc primitive: primitive mvn(net.mintern:primitive) mvn(net.mintern:primitive:pom:) Source checksums ---------------- https://github.com/mintern-java/primitive/archive/1.2.2.tar.gz : CHECKSUM(SHA256) this package : 065a30fa25cd85b2b70d284b7a4aab4e17d21f4ad269db1dcefe98f9faad2a16 CHECKSUM(SHA256) upstream package : 065a30fa25cd85b2b70d284b7a4aab4e17d21f4ad269db1dcefe98f9faad2a16 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1329201 --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Is there anything else besides the license? --- SPECS/old/primitive.spec 2016-04-21 15:10:15.000000000 +0200 +++ SPECS/primitive.spec 2016-04-25 10:53:13.436371607 +0200 @@ -2,13 +2,14 @@ Version: 1.2.2 Release: 2%{?dist} Summary: Utility methods for Java's primitive types -License: GPLv2 with exceptions -URL: https://github.com/mintern-java/primitive/ -Source0: https://github.com/mintern-java/primitive/archive/%{version}.tar.gz +# GNU General Public License v2.0 or later, with Classpath exception +License: GPLv2+ +URL: https://github.com/mintern-java/%{name}/ +Source0: https://github.com/mintern-java/%{name}/archive/%{version}.tar.gz # https://bugzilla.redhat.com/show_bug.cgi?id=1212672 Source1: fmpp.sh # https://github.com/mintern-java/primitive/issues/5 -Patch0: https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch +Patch0: https://github.com/mintern-java/%{name}/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch BuildRequires: maven-local BTW here is koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13793714
(In reply to Tomas Repik from comment #5) > Is there anything else besides the license? > > --- SPECS/old/primitive.spec 2016-04-21 15:10:15.000000000 +0200 Correct license > -License: GPLv2 with exceptions Wrong license > +License: GPLv2+ > > BTW here is koji: > http://koji.fedoraproject.org/koji/taskinfo?taskID=13793714
(In reply to gil cattaneo from comment #6) > Correct license > > -License: GPLv2 with exceptions Yes you're right I got confused by the plus in: "All source files are licensed under GPLv2+CE" in the LICENSE.txt file [1] Here is once again the diff: --- SPECS/old/primitive.spec 2016-04-21 15:10:15.000000000 +0200 +++ SPECS/primitive.spec 2016-04-26 12:10:57.854293972 +0200 @@ -2,13 +2,18 @@ Version: 1.2.2 Release: 2%{?dist} Summary: Utility methods for Java's primitive types +# DualPivotQuicksorts.java.ft is also Copyright 2009, 2015, Oracle and/or its +# affiliates. +# TimSorts.java.ft is also Copyright 2009, 2013, Oracle and/or its affiliates, +# and Copyright 2009 Google Inc. +# GNU General Public License v2.0 or later, with Classpath exception License: GPLv2 with exceptions -URL: https://github.com/mintern-java/primitive/ -Source0: https://github.com/mintern-java/primitive/archive/%{version}.tar.gz +URL: https://github.com/mintern-java/%{name}/ +Source0: https://github.com/mintern-java/%{name}/archive/%{version}.tar.gz # https://bugzilla.redhat.com/show_bug.cgi?id=1212672 Source1: fmpp.sh # https://github.com/mintern-java/primitive/issues/5 -Patch0: https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch +Patch0: https://github.com/mintern-java/%{name}/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch [1] https://raw.githubusercontent.com/mintern-java/primitive/master/LICENSE.txt
Approved
Spec URL: https://trepik.fedorapeople.org/primitive-java/v2/primitive.spec SRPM URL: https://trepik.fedorapeople.org/primitive-java/v2/primitive-1.2.2-2.fc23.src.rpm * Wed Apr 27 2016 Tomas Repik <trepik> - 1.2.2-2 - new patch for license headers Thanks for the review! Adding this just to be clear, and documented.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/primitive
primitive-1.2.2-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-12700be6f6
primitive-1.2.2-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-12700be6f6
primitive-1.2.2-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.