Bug 1329224 - [Host QoS] - It's not possible to set an anonymous QoS on a network via the setup networks
Summary: [Host QoS] - It's not possible to set an anonymous QoS on a network via the s...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.0.0
Hardware: x86_64
OS: Linux
medium
high
Target Milestone: ovirt-4.0.1
: 4.0.1.1
Assignee: Martin Mucha
QA Contact: Meni Yakove
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-21 12:57 UTC by Michael Burman
Modified: 2016-07-19 06:25 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: wrong code reuse Consequence: inability to add overriding QoS, since such override is not named, while validation asserted present name. Fix: used separate objects for QoS and anonymous, overriding QoS Result: OK.
Clone Of:
Environment:
Last Closed: 2016-07-19 06:25:06 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.0.z+
rule-engine: blocker+
rule-engine: planning_ack+
rule-engine: devel_ack+
myakove: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 53833 0 master MERGED core: removed duplicity + moved method to appropriate place 2016-06-20 11:38:00 UTC
oVirt gerrit 53834 0 master MERGED core: Extracted HostNetworkQos properties to separate class 2016-06-20 11:38:52 UTC
oVirt gerrit 53835 0 master MERGED core: NetworkAttachment should use AnonymousHostNetworkQos 2016-06-20 11:39:52 UTC
oVirt gerrit 59539 0 ovirt-engine-4.0 MERGED core: removed duplicity + moved method to appropriate place 2016-06-29 13:54:16 UTC
oVirt gerrit 59540 0 ovirt-engine-4.0 MERGED core: Extracted HostNetworkQos properties to separate class 2016-06-29 13:54:00 UTC
oVirt gerrit 59541 0 ovirt-engine-4.0 MERGED core: NetworkAttachment should use AnonymousHostNetworkQos 2016-06-29 13:53:32 UTC

Description Michael Burman 2016-04-21 12:57:39 UTC 
Description of problem:
[Host QoS] - It's not possible to set an Anonymous QoS on a network via the setup networks.

When trying to set Anonymous QoS and approve operation, operation canceled with error:
Error while executing action: 

orchid-vds1.qa.lab.tlv.redhat.com:
Cannot setup Networks. Invalid data center.
QoS name cannot be empty.

engine.log 

 2016-04-21 15:49:57,936 WARN  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (default task-13) [6f9f90a] Validation of action 'HostSetupNetworks' failed for user admin@internal. Reasons: VAR__ACTION__SETUP,VAR__TYPE__NETWORKS,ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_EXIST,QOS_NAME_NOT_NULL
2016-04-21 15:49:57,936 INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (default task-13) [6f9f90a] Lock freed to object 'EngineLock:{exclusiveLocks='[47c576e4-7862-4a92-99d1-51ffe7dbc9e0=<HOST_NETWORK, ACTION_TYPE_FAILED_SETUP_NETWORKS_IN_PROGRESS>]', sharedLocks='null'}'


Version-Release number of selected component (if applicable):
4.0.0-0.0.master.20160404161620.git4ffd5a4.el7.centos

How reproducible:
100

Steps to Reproduce:
1. Attach network to host via setup networks and set Anonymous QoS on the network, try to approve operation


Actual results:
Operation canceled with error

Expected results:
Should work as expected
Comment 1 Red Hat Bugzilla Rules Engine 2016-04-21 13:00:38 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 2 Red Hat Bugzilla Rules Engine 2016-04-25 16:24:08 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 3 Sandro Bonazzola 2016-05-02 10:08:28 UTC 
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
Comment 4 Yaniv Lavi 2016-05-23 13:22:57 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 5 Yaniv Lavi 2016-05-23 13:25:27 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 6 Meni Yakove 2016-07-02 07:48:25 UTC 
rhevm-4.0.2-0.2.rc1.el7ev.noarch
Comment 7 Sandro Bonazzola 2016-07-19 06:25:06 UTC 
Since the problem described in this bug report should be
resolved in oVirt 4.0.1 released on July 19th 2016, it has been closed with a
resolution of CURRENT RELEASE.

For information on the release, and how to update to this release, follow the link below.

If the solution does not work for you, open a new bug report.

http://www.ovirt.org/release/4.0.1/
Note You need to log in before you can comment on or make changes to this bug.