Spec URL: https://jpena.fedorapeople.org/python-cradox/python-cradox.spec SRPM URL: https://jpena.fedorapeople.org/python-cradox/python-cradox-1.1.8-1.fc25.src.rpm Description: Python libraries for the Ceph librados library with use cython instead of ctypes Fedora Account System Username: jpena Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=13748408
CentOS CloudSIG CBS build https://cbs.centos.org/koji/buildinfo?buildID=10636 is now in openstack-common testing repo
> Source0: https://pypi.python.org/packages/source/c/%{pypi_name}/%{pypi_name}-%{version}.tar.gz Replace with https://files.pythonhosted.org/packages/source/c/%{pypi_name}/%{pypi_name}-%{version}.tar.gz pypi broke old download URLs, see post "New PyPI link format for Python packages" https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/4X2XGKEVXYUE2L7W3LSRTDF56ZN4EILD/ Other than that, fedora-review reported: * Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.5/site-packages, /usr/lib64/python3.5 * E: explicit-lib-dependency librados2 let RPM automatically add it * W: invalid-license LGPL 2.1 LGPLv2 see https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
> * Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib64/python3.5/site-packages, > /usr/lib64/python3.5 ignore that one, must be Fedora Rawhide issue w/ python3.5, not reproducible on Fedora23 with python3.4
Created attachment 1166400 [details] spec changes to resolve reported issues
I have updated the SPEC and SRPM, including another fix (/usr/lib and /usr/src were not using macros). SPEC: https://jpena.fedorapeople.org/python-cradox/python-cradox.spec SRPM: https://jpena.fedorapeople.org/python-cradox/python-cradox-1.1.8-2.fc25.src.rpm Koji scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=14448018
Drop BR:gcc and we're good.
I've dropped gcc from the BR. SPEC: https://jpena.fedorapeople.org/python-cradox/python-cradox.spec SRPM: https://jpena.fedorapeople.org/python-cradox/python-cradox-1.1.8-3.fc26.src.rpm Koji scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=15092892
Approved Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/haikel/1329340-python- cradox/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-cradox , python-cradox-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-cradox-1.1.8-3.el7.x86_64.rpm python-cradox-debuginfo-1.1.8-3.el7.x86_64.rpm python-cradox-1.1.8-3.el7.src.rpm python2-cradox.x86_64: W: spelling-error Summary(en_US) librados -> Libras python2-cradox.x86_64: W: spelling-error Summary(en_US) cython -> python, Python python2-cradox.x86_64: W: spelling-error Summary(en_US) ctypes -> types, c types python2-cradox.x86_64: W: spelling-error %description -l en_US librados -> Libras python2-cradox.x86_64: W: spelling-error %description -l en_US cython -> python, Python python2-cradox.x86_64: W: spelling-error %description -l en_US ctypes -> types, c types python-cradox.src: W: spelling-error Summary(en_US) librados -> Libras python-cradox.src: W: spelling-error Summary(en_US) cython -> python, Python python-cradox.src: W: spelling-error Summary(en_US) ctypes -> types, c types python-cradox.src: W: spelling-error %description -l en_US librados -> Libras python-cradox.src: W: spelling-error %description -l en_US cython -> python, Python python-cradox.src: W: spelling-error %description -l en_US ctypes -> types, c types 3 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: python-cradox-debuginfo-1.1.8-3.el7.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python-cradox-debuginfo.x86_64: W: invalid-url URL: https://github.com/sileht/pycradox <urlopen error [Errno -2] Name or service not known> python-cradox-debuginfo.x86_64: W: only-non-binary-in-usr-lib python2-cradox.x86_64: W: invalid-url URL: https://github.com/sileht/pycradox <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- python-cradox-debuginfo (rpmlib, GLIBC filtered): python2-cradox (rpmlib, GLIBC filtered): Cython libc.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) librados.so.2()(64bit) python(abi) rtld(GNU_HASH) Provides -------- python-cradox-debuginfo: python-cradox-debuginfo python-cradox-debuginfo(x86-64) python2-cradox: python-cradox python2-cradox python2-cradox(x86-64) Unversioned so-files -------------------- python2-cradox: /usr/lib64/python2.7/site-packages/cradox.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/c/cradox/cradox-1.1.8.tar.gz : CHECKSUM(SHA256) this package : 51d56f6702261d6fbbc2b8ba148c1138cc98642bd094ac2ab1760605aba69396 CHECKSUM(SHA256) upstream package : 51d56f6702261d6fbbc2b8ba148c1138cc98642bd094ac2ab1760605aba69396 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1329340 -m rdo-mitaka-el7 Buildroot used: cloud7-openstack-mitaka-el7-build Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-cradox
Package built on Rawhide (http://koji.fedoraproject.org/koji/buildinfo?buildID=796540), closing bug.