So that we can use /dev in privileged containers. See https://bugzilla.redhat.com/show_bug.cgi?id=1329326

I had already opened a PR https://github.com/projectatomic/docker/pull/131. We'll go ahead and merge it. Thanks for testing.

Scott does my fix breaks something? Just want to make sure the introduction of this fix does not regress on something else.

We haven't had time to test it yet. I believe this is only known to have happened on atomic host which means we have to build a new os-tree to bring this in. Hopefully we can get it tested today.

Merged, lets do a build.

*** Bug 1329326 has been marked as a duplicate of this bug. ***

Reproducer, perform a containerized install of Origin using atomic host.

1) Provision an atomic host machine, below we assume the hostname is 'ose3-master.example.com'
2) git clone https://github.com/openshift/openshift-ansible
3) cat <<EOF> ~/bz1329424
[OSEv3:children]
masters
nodes

[OSEv3:vars]
deployment_type=openshift-enterprise
containerized=true
ansible_ssh_user=root

[masters]
ose3-master.example.com

[nodes]
ose3-master.example.com openshift_node_labels="{'region': 'infra', 'zone': 'default'}"
EOF

4) ansible-playbook -i ~/bz1329424 openshift-ansible/playbooks/byo/config.yml

SSH into atomic host as non-root user.

I could verified this with steps below

Assume has a host 10.66.0.137
#useradd test
#passwd test
redhat

#docker run -v /dev/:/dev/ -it rhel:latest /bin/bash

Then SSH to the host with another machine
#ssh test@10.66.0.137

In previous version, i met
$ ssh test@10.66.3.137 -X
test@10.66.3.137's password: 
X11 forwarding request failed on channel 0
PTY allocation request failed on channel 0

in docker-1.9.1-38.el7.x86_64
$ ssh test@10.66.0.137 -X
test@10.66.0.137's password: 
X11 forwarding request failed on channel 0
Last login: Tue May  3 20:19:02 2016 from 10.66.70.123
[test@dhcp-0-137 ~]$ 


Just one question here:
Once the terminal fall in "PTY error", i can't recover it , like
* Use 1.9.1-30 mount the /dev in container -> PTY error
   * update to 1.9.1-38, container can' start with -v /dev/:/dev/ and still met the PTY error with non-root user via ssh

* Use 1.9.1-38 mount the /dev in container -> everything will be okay

I'd like to know is it expected

Yes this is what is expected.

(In reply to Daniel Walsh from comment #13)
> Yes this is what is expected.

thanks ! move to verified

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-1034.html