Bug 1329455 - [quick-install] Cannot add new nodes in pre-existing env
Summary: [quick-install] Cannot add new nodes in pre-existing env
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: ---
Assignee: Samuel Munilla
QA Contact: Gan Huang
URL:
Whiteboard:
Depends On: 1366595
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-22 02:24 UTC by Gan Huang
Modified: 2016-08-18 19:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, the quick installer had issues adding new nodes to existing clusters in certain configurations. This bug fix updates the installer to properly identify these configurations and allow new nodes to be added as expected.
Clone Of:
Environment:
Last Closed: 2016-08-18 19:28:13 UTC
Target Upstream Version:
Embargoed:
ghuang: needinfo-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1639 0 normal SHIPPED_LIVE OpenShift Enterprise atomic-openshift-utils bug fix and enhancement update 2016-08-18 23:26:45 UTC

Description Gan Huang 2016-04-22 02:24:53 UTC
Description of problem:
quick-installer will pass the process of adding new nodes in pre-existing env.

Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.0.82-1.git.0.5e5b4bf.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.Install a env with 1 master and 1 storage by quick-installer
2.Add a new node in above env.


Actual results:
*** Installation Summary ***

Hosts:
- x.x.172.101
  - OpenShift Master
  - OpenShift Node
  - Etcd (Embedded)
- x.x.172.86
  - Storage

Total OpenShift Masters: 1
Total OpenShift Nodes: 1

NOTE: Add a total of 3 or more Masters to perform an HA installation.

Gathering information from hosts...
Installed environment detected.
By default the installer only adds new nodes to an installed environment.
Do you want to (1) only add additional nodes or (2) reinstall the existing hosts potentially erasing any custom changes?: 1
x.x.172.101 is already an OpenShift Master
x.x.172.86 is currently uninstalled
Adding additional nodes...

Wrote atomic-openshift-installer config: /root/.config/openshift/installer.cfg.yml
Wrote ansible inventory: /root/.config/openshift/hosts

Ready to run installation process.

If changes are needed please edit the config file above and re-run.

Are you ready to continue? [y/N]: y

PLAY [Populate config host groups] ******************************************** 



Expected results:
add nodes successfully

Additional info:

Comment 3 Samuel Munilla 2016-06-17 19:51:46 UTC
I just opened up https://github.com/openshift/openshift-ansible/pull/2062 which should catch both detecting master_lb's and storage hosts as installed

Comment 7 Gan Huang 2016-08-12 17:46:45 UTC
If i installed a ha env by quick-installer:

# cat /hosts 

[OSEv3:children]
nodes
nfs
masters
lb
etcd

[OSEv3:vars]
ansible_ssh_user=root
openshift_master_cluster_method=native
openshift_master_cluster_hostname=openshift-103.lab.eng.nay.redhat.com
openshift_master_cluster_public_hostname=openshift-103.lab.eng.nay.redhat.com
deployment_type=openshift-enterprise

[nodes]
openshift-127.lab.eng.nay.redhat.com  openshift_ip=192.168.2.157 openshift_public_ip=10.66.147.127 openshift_hostname=openshift-127.lab.eng.nay.redhat.com openshift_public_hostname=openshift-127.lab.eng.nay.redhat.com openshift_node_labels="{'region': 'infra'}" openshift_schedulable=False
openshift-111.lab.eng.nay.redhat.com  openshift_ip=192.168.2.158 openshift_public_ip=10.66.147.111 openshift_hostname=openshift-111.lab.eng.nay.redhat.com openshift_public_hostname=openshift-111.lab.eng.nay.redhat.com openshift_node_labels="{'region': 'infra'}" openshift_schedulable=False
openshift-112.lab.eng.nay.redhat.com  openshift_ip=192.168.2.159 openshift_public_ip=10.66.147.112 openshift_hostname=openshift-112.lab.eng.nay.redhat.com openshift_public_hostname=openshift-112.lab.eng.nay.redhat.com openshift_schedulable=False
openshift-103.lab.eng.nay.redhat.com  openshift_ip=192.168.2.160 openshift_public_ip=10.66.147.103 openshift_hostname=openshift-103.lab.eng.nay.redhat.com openshift_public_hostname=openshift-103.lab.eng.nay.redhat.com openshift_schedulable=True

[nfs]
openshift-121.lab.eng.nay.redhat.com  openshift_ip=192.168.2.161 openshift_public_ip=10.66.147.121 openshift_hostname=openshift-121.lab.eng.nay.redhat.com openshift_public_hostname=openshift-121.lab.eng.nay.redhat.com

[masters]
openshift-127.lab.eng.nay.redhat.com  openshift_ip=192.168.2.157 openshift_public_ip=10.66.147.127 openshift_hostname=openshift-127.lab.eng.nay.redhat.com openshift_public_hostname=openshift-127.lab.eng.nay.redhat.com
openshift-111.lab.eng.nay.redhat.com  openshift_ip=192.168.2.158 openshift_public_ip=10.66.147.111 openshift_hostname=openshift-111.lab.eng.nay.redhat.com openshift_public_hostname=openshift-111.lab.eng.nay.redhat.com
openshift-112.lab.eng.nay.redhat.com  openshift_ip=192.168.2.159 openshift_public_ip=10.66.147.112 openshift_hostname=openshift-112.lab.eng.nay.redhat.com openshift_public_hostname=openshift-112.lab.eng.nay.redhat.com

[lb]
openshift-103.lab.eng.nay.redhat.com  openshift_ip=192.168.2.160 openshift_public_ip=10.66.147.103 openshift_hostname=openshift-103.lab.eng.nay.redhat.com openshift_public_hostname=openshift-103.lab.eng.nay.redhat.com

[etcd]
openshift-127.lab.eng.nay.redhat.com  openshift_ip=192.168.2.157 openshift_public_ip=10.66.147.127 openshift_hostname=openshift-127.lab.eng.nay.redhat.com openshift_public_hostname=openshift-127.lab.eng.nay.redhat.com
openshift-111.lab.eng.nay.redhat.com  openshift_ip=192.168.2.158 openshift_public_ip=10.66.147.111 openshift_hostname=openshift-111.lab.eng.nay.redhat.com openshift_public_hostname=openshift-111.lab.eng.nay.redhat.com
openshift-112.lab.eng.nay.redhat.com  openshift_ip=192.168.2.159 openshift_public_ip=10.66.147.112 openshift_hostname=openshift-112.lab.eng.nay.redhat.com openshift_public_hostname=openshift-112.lab.eng.nay.redhat.com


quick-installer will still fail to add new nodes due to nfs host can't be identified to a installed/uninstalled host.

Comment 8 Gan Huang 2016-08-12 17:47:34 UTC
Proposed PR: https://github.com/openshift/openshift-ansible/pull/2292

Comment 9 openshift-github-bot 2016-08-15 18:43:57 UTC
Commit pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/58819b9243e72482729fce3ff24b414c461431ab
Merge pull request #2297 from abutcher/bz#1329455

a-o-i: Bug1329455, [quick-install] Cannot add new nodes in pre-existing env

Comment 12 Gan Huang 2016-08-16 06:26:16 UTC
Verified with atomic-openshift-utils-3.2.23-1.git.0.af9440e.el7.noarch

New nodes can be added sussfully in the scenario of comment 7.`

Comment 14 errata-xmlrpc 2016-08-18 19:28:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1639


Note You need to log in before you can comment on or make changes to this bug.