Spec URL: https://peter.fedorapeople.org/packages/erlang-setup.spec SRPM URL: https://peter.fedorapeople.org/packages/erlang-setup-1.7-1.fc24.src.rpm Description: While Erlang/OTP comes with many wonderful applications, including the Mnesia DBMS, there is no standard or convention for installing a system. Erlang/OTP provides tools for building a boot script, and rules for setting environment variables, etc., and Mnesia offers an API for creating and modifying the database schema. However, with no convention for when these tools and API functions are called - and by whom - application developers are left having to invent a lot of code and scripts, not to mention meditate over chapters of Erlang/OTP documentation in order to figure out how things fit together. This utility offers a framework for initializing and configuring a system, with a set of conventions allowing each component to provide callbacks for different steps in the installation procedure. The callbacks are defined through OTP application environment variables, which can easily be overriden at install time. Fedora Account System Username: peter
There are some important things to fix before you put this into Fedora about the licensing, so please make sure you take a look at the !'s below before building in Rawhide. Other than that, there is a spelling error in the description. LGTM! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. rbarlow: Please add the %license macro as well. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MPL (v2.0)". 9 files have unknown license. Detailed output of licensecheck in /home/rbarlow/review/1329852-erlang-setup/licensecheck.txt rbarlow: The license is MPL 2.0, not ASL 2.0. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 11 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== rbarlow: [!]: Overridden is misspelled in the description. I submitted a PR upstream to fix this in their readme: https://github.com/uwiger/setup/pull/26 Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-setup-1.7-1.fc25.x86_64.rpm erlang-setup-1.7-1.fc25.src.rpm erlang-setup.x86_64: W: spelling-error %description -l en_US overriden -> override, overridden, overrides erlang-setup.x86_64: E: no-binary erlang-setup.x86_64: W: only-non-binary-in-usr-lib erlang-setup.src: W: spelling-error %description -l en_US overriden -> override, overridden, overrides 2 packages and 0 specfiles checked; 1 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory erlang-setup.x86_64: W: spelling-error %description -l en_US overriden -> override, overridden, overrides erlang-setup.x86_64: E: no-binary erlang-setup.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Requires -------- erlang-setup (rpmlib, GLIBC filtered): erlang-erts(x86-64) erlang-kernel(x86-64) erlang-sasl(x86-64) erlang-stdlib(x86-64) Provides -------- erlang-setup: erlang-setup erlang-setup(x86-64) Source checksums ---------------- https://github.com/uwiger/setup/archive/1.7/setup-1.7.tar.gz : CHECKSUM(SHA256) this package : add01c6d6b972a1335d594681b2ec4204bd7dc3235db1901e3b9ee044a51e7b9 CHECKSUM(SHA256) upstream package : add01c6d6b972a1335d594681b2ec4204bd7dc3235db1901e3b9ee044a51e7b9 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1329852 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/erlang-setup
erlang-setup-1.7-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-60984c635a
erlang-setup-1.7-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-60984c635a
erlang-setup-1.7-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.