Bug 1329870 - Lots of [global.glusterfs - usage-type (null) memusage] are seen in statedump
Summary: Lots of [global.glusterfs - usage-type (null) memusage] are seen in statedump
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-24 01:10 UTC by Pranith Kumar K
Modified: 2016-06-16 14:04 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
Environment:
Last Closed: 2016-06-16 14:04:01 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2016-04-24 01:10:19 UTC
Description of problem:
    After the commits: 7e44c783ad731856956929f6614bbe045c26ea3a - lock: use
    spinlock only on multicore systems
    a6aecae2cd8171b8538bfe5d2800bdd157380b85 - nfs: fix lock variable type
    
    we see a lot of "[global.glusterfs - usage-type (null) memusage]" in statedump
    because lock status is not all-zeros after init, and the memcmp to check that
    a datatype is never allocated is invalid.
    


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Take statedump
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-04-24 01:15:52 UTC
REVIEW: http://review.gluster.org/14054 (statedump: Prevent (null) typestr to be printed) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-04-24 05:35:39 UTC
REVIEW: http://review.gluster.org/14054 (statedump: Prevent (null) typestr to be printed) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Vijay Bellur 2016-04-24 13:44:46 UTC
COMMIT: http://review.gluster.org/14054 committed in master by Niels de Vos (ndevos) 
------
commit 3c04a91f5245708d0a148bf01cfdac1d0d59c797
Author: Pranith Kumar K <pkarampu>
Date:   Sun Apr 24 06:31:14 2016 +0530

    statedump: Prevent (null) typestr to be printed
    
    Problem:
    After the commits: 7e44c783ad731856956929f6614bbe045c26ea3a - lock: use
    spinlock only on multicore systems
    a6aecae2cd8171b8538bfe5d2800bdd157380b85 - nfs: fix lock variable type
    
    we see a lot of "[global.glusterfs - usage-type (null) memusage]" in statedump
    because lock status is not all-zeros after init, and the memcmp to check that
    a datatype is never allocated is invalid.
    
    Fix:
    Changed if a datatype is allocated or not check based on total_allocs. Also
    removed setting typestr to NULL on gf_free even when num_allocs is 0. Because
    even that is leading to 'null' memusage string to be printed in statedump.
    
    BUG: 1329870
    Change-Id: If2b01a557cbdc787625db32e276e06cee3ac46ee
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/14054
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Niels de Vos 2016-06-16 14:04:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.