Bug 1329908 - [comps] LXQt group description is the same as for LXDE, may confuse users to see two list entries for LXDE
Summary: [comps] LXQt group description is the same as for LXDE, may confuse users to ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: comps
Version: 24
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact:
URL:
Whiteboard: RejectedBlocker
Depends On:
Blocks: LXQt
TreeView+ depends on / blocked
 
Reported: 2016-04-24 18:36 UTC by Raphael Groner
Modified: 2016-07-21 10:57 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-21 10:57:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot with duplicated LXDE in left column (186.93 KB, image/png)
2016-04-24 20:54 UTC, Raphael Groner
no flags Details
screenshot with duplicated LXDE in right column (185.85 KB, image/png)
2016-04-24 20:54 UTC, Raphael Groner
no flags Details
diff *.po lxde vs. lxqt (1.38 KB, text/plain)
2016-04-25 08:36 UTC, Raphael Groner
no flags Details
po.patch (78.92 KB, patch)
2016-05-08 18:18 UTC, Raphael Groner
no flags Details | Diff

Description Raphael Groner 2016-04-24 18:36:04 UTC
Description of problem:
Fedora 24 netinstall shows two list entries for additional package group installation options in Anaconda.

Version-Release number of selected component (if applicable):
Fedora-Server-netinst-x86_64-24-20160423.n.0.iso

How reproducible:
yes

Steps to Reproduce:
1. download Server livemedia
2. boot image
3. work through Anaconda to install minimal Xorg and look at additional installable groups option list

Actual results:
LXDE is listed twice, in both left and right column

Expected results:
LXQt is avaiable in list options

Additional info:
A good guess is that LXQt group has the same description as LXDE has, so the user is unable to difference between both. When both are checked and get installed, it's possible to login in a LXDE session as well in LXQt session.

Comment 1 Fedora Blocker Bugs Application 2016-04-24 18:48:10 UTC
Proposed as a Blocker for 24-beta by Fedora user raphgro using the blocker tracking app because:

 This bug violates some test cases in their expectation criterions. There must not be conflicting installation options. The description for LXQt option has to be changed to be uniquely found for an user.

https://fedoraproject.org/wiki/QA:Testcase_Package_Sets_Minimal_Package_Install
https://fedoraproject.org/wiki/QA/TestCases/PackageSetsEverythingPackageInstall

Comment 2 Raphael Groner 2016-04-24 18:48:25 UTC
There must not be conflicting installation options. The description for LXQt option has to be changed to be uniquely found for an user.

Comment 3 Adam Williamson 2016-04-24 19:35:04 UTC
This doesn't violate anything in the minimal test case, and the everything test case is optional and doesn't cover any release criteria. There's no criterion violation here that I can see, so -1 blocker.

Comment 4 Raphael Groner 2016-04-24 19:47:03 UTC
A duplicated entry in a list of installation options does not look right to me. Besides one of both entries is misleading cause it installs packages for/of LXQt instead of LXDE as it promises.

Comment 5 Raphael Groner 2016-04-24 19:48:05 UTC
Getting LXQt maintainers into the boat.

Comment 6 Adam Williamson 2016-04-24 20:43:59 UTC
I didn't say it's not a *bug*, I just said it's not a *release blocker* :)

I'm not entirely sure what you're describing, though. There is an "LXQt Desktop" environment group which is different from the "LXDE Desktop" environment group, and there are "LXDE" and "LXQt" package groups, neither of which is set user-visible. Could you post a screenshot? Thanks!

Comment 7 Raphael Groner 2016-04-24 20:47:41 UTC
Hmm, maybe it's just an l10n thingy. I used Anaconda with german translations.

Comment 8 Raphael Groner 2016-04-24 20:54:13 UTC
Created attachment 1150217 [details]
screenshot with duplicated LXDE in left column

Comment 9 Raphael Groner 2016-04-24 20:54:43 UTC
Created attachment 1150218 [details]
screenshot with duplicated LXDE in right column

Comment 10 Raphael Groner 2016-04-24 20:57:49 UTC
I can confirm this is a l10n bug. When I run Anaconda in english mode, I get the second option shown as LXQt uniquely. What component should I assign this bug?

Comment 11 Fedora Blocker Bugs Application 2016-04-24 21:23:55 UTC
Proposed as a Blocker for 24-final by Fedora user raphgro using the blocker tracking app because:

 This bug should be a final blocker. It somehow violates an usable localization of Anaconda and shows broken string freeze.

This test case tests installation using a non-English European language. Testing also includes verifying a good keymap is selected during installation and used for all purposes in the installed system. 

https://fedoraproject.org/wiki/QA:Testcase_Non-English_European_Language_Install

Comment 12 Adam Williamson 2016-04-25 05:06:47 UTC
comps, it's an issue in the comps translations. I'm not sure if those are considered subject to the string freeze; since comps and spin-kickstarts are just git repos, they kinda don't exactly get affected by the freeze processes as they apply to packages.

This still does not qualify as a blocker for me. Neither that test case nor the criteria it covers say anything about mistakes in translations, especially in something non-critical like the name of a non-blocking environment's groups.

Comment 13 Raphael Groner 2016-04-25 07:08:34 UTC
> since comps and spin-kickstarts are just git repos

Please guide me to the files with the translation strings, then we can try to improve (at least) the german text and look for other propably false translations.

Comment 14 Adam Williamson 2016-04-25 07:24:09 UTC
https://git.fedorahosted.org/cgit/comps.git/tree/po

Comment 15 Raphael Groner 2016-04-25 08:36:14 UTC
Created attachment 1150299 [details]
diff *.po lxde vs. lxqt

$ grep -ci lxde *.po >lxde.log
$ grep -ci lxqt *.po >lxqt.log

$ diff lxde.log lxqt.log

Comment 16 Kevin Fenzi 2016-04-25 15:45:49 UTC
comps is translated in zanata:

https://fedora.zanata.org/project/view/comps

Please submit your changes via there.

Comment 17 Tim Flink 2016-05-02 17:04:25 UTC
Discussed in the 2016-05-02 blocker review meeting.

Rejected as a release blocking bug for F24 final because it does not violate any of the release criteria.

Comment 18 Raphael Groner 2016-05-08 18:18:30 UTC
Created attachment 1155106 [details]
po.patch

I hope I found all wrong LXDE and corrected with LXQt. Besides that, sometimes MATE is wrongly translated with LXDE.

Comment 19 Raphael Groner 2016-05-08 19:23:07 UTC
German texts corrected in zanata.

Comment 20 Kevin Fenzi 2016-05-08 22:26:00 UTC
Thanks, pulled from zanata and pushed into comps. ;)

should be able to verify it in tomorrow's nightly f24 or rawhide.

Comment 21 Stephen Gallagher 2016-07-20 15:33:45 UTC
Is this fixed? Please close this BZ if so.

Comment 22 Raphael Groner 2016-07-21 10:57:59 UTC
LGTM Thanks!


Note You need to log in before you can comment on or make changes to this bug.