Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1329954 - Bond can not click to on after created through cockpit
Bond can not click to on after created through cockpit
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: cockpit (Show other bugs)
7.2
Unspecified Unspecified
urgent Severity high
: pre-dev-freeze
: 7.2
Assigned To: Dominik Perpeet
Jan Ščotka
: Extras
Depends On:
Blocks: ovirt-node-ng-platform
  Show dependency treegraph
 
Reported: 2016-04-25 04:05 EDT by wanghui
Modified: 2016-09-10 07:50 EDT (History)
12 users (show)

See Also:
Fixed In Version: cockpit-0.114-2
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-08-04 09:46:51 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Node
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1442 normal SHIPPED_LIVE cockpit bug fix and enhancement update 2016-08-04 13:45:50 EDT

  None (edit)
Description wanghui 2016-04-25 04:05:35 EDT
Description of problem:
After configured bond in cockpit, the bond can not be check to on. And there is no save button for us to save the changes in "General" field.

Version-Release number of selected component (if applicable):
ovirt-node-ng-installer-ovirt-3.6-2016042323.iso 
cockpit-0.103-1.el7.centos.x86_64
cockpit-ovirt-0.5.1-0.0.master.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Anaconda install NGN 4.0.
2. Start cockpit service.
3. Configue bond with mode "Round Robin".
4. Check "On" button in cockpit.
5. Check the 'General' field to enable connect automatically.
6. Check the members field.

Actual results:
1. After step4, the 'On' button can not be checked.
2. After step5, miss save button to save the changes in "General" field. 
3. After step6, the members can be configured individually.

Expected results:
1. Bond can be up after configured in cockpit.
2. Since bond is a new bridge to treat all nics as slaves, it should not let the salves to be configured individually.

Additional info:
Comment 1 Fabian Deutsch 2016-04-25 04:25:15 EDT
Please try to reproduce this on RHEL. You will need to enable RHEL extras to retrieve cockpit.
Comment 2 wanghui 2016-04-26 05:52:44 EDT
Since this issue is move to cockpit part, I would like to wait cockpit guys to debug this issue.
Comment 4 Fabian Deutsch 2016-05-24 10:27:33 EDT
Wei, does this mean a bond can not be enabled and be saved?
Comment 5 wanghui 2016-05-26 00:44:29 EDT
(In reply to Fabian Deutsch from comment #4)
> Wei, does this mean a bond can not be enabled and be saved?

yes, the enable button for bond can not be clicked.
Comment 6 Marius Vollmer 2016-06-27 07:06:46 EDT
Please also state the version of NetworkManager.
Comment 7 Marius Vollmer 2016-06-27 07:27:11 EDT
> After step5, miss save button to save the changes in "General" field. 

There is no need to explicitly save this setting.  It will be saved as soon as you change it.
Comment 8 Marius Vollmer 2016-06-27 07:56:13 EDT
> yes, the enable button for bond can not be clicked.

Confirmed.

What I can observe:

- Switching off a bond will also switch off all slaves.
- Switching on a bond whose slaves are all off will do nothing.  (This is the bug.)
- Switching off all slaves of a bond will keep the bond on.
- Switching on a slave of a bond that is off will switch on the bond as well.

Using nmcli to activate a bond connection whose slaves are all off does successfully activate the bond.  One needs to also explicitly switch on the slaves, however.  This is what should happen with Cockpit also and I'll fix that.

Whether or not activating a bond connection should connect the slaves a well... This looks like something that NetworkManager should decide and take care off.  We want this to be consistent between Cockpit and nmcli, for example, and I'll make sure that Cockpit matches nmcli.  If you are unhappy with the behavior of nmcli, please file a bug against NetworkManager.

(I have observed different behavior on different OSes at different times and can't figure out the pattern.  That's why I kept all the individual slave on/off buttons in the UI.  They seem to be necessary since NetworkManager does not seem to manage the slaves well enough.  I guess we need to revisit that also.)
Comment 9 Marius Vollmer 2016-06-27 09:17:31 EDT
https://github.com/cockpit-project/cockpit/pull/4640

Turns out the on/off switch was erroneously disabled, but this wasn't reflected in its looks.

So, two bugs:

 - the on/off switch should not be disabled for inactive bonds.
 - the on/off switch should actually _look_ disabled when it _is_ disabled.

Both are fixed in the linked pull request.
Comment 11 Stef Walter 2016-07-05 15:20:25 EDT
This bug will be fixed in cockpit 0.113

https://github.com/cockpit-project/cockpit/pull/4640

Reassigning to Dominik for inclusion in next RHEL release of Cockpit.
Comment 16 errata-xmlrpc 2016-08-04 09:46:51 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1442.html

Note You need to log in before you can comment on or make changes to this bug.