Red Hat Bugzilla – Bug 1330091
broken symlinks to filter_plugins and lookup_plugins
Last modified: 2016-09-27 05:31:19 EDT
Description of problem: The Ansible installer RPM ships with broken symlinks on the following locations: /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins Version-Release number of selected component (if applicable): openshift-ansible-playbooks-3.0.47-6.git.0.7e39163.el7aos.noarch How reproducible: always Steps to Reproduce: 1. install openshift-ansible-playbooks 2. check the following symlinks: /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins Actual results: symlinks broken # ls -la /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins lrwxrwxrwx. 1 root root 20 Apr 13 14:37 /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins -> ../../filter_plugins # ls -la /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins lrwxrwxrwx. 1 root root 20 Apr 13 14:37 /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins -> ../../lookup_plugins # cd /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins -bash: cd: /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins: No such file or directory # cd /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins -bash: cd: /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins: No such file or directory Expected results: symlinks work (or don't even exist if not needed) Additional info: correct symlink destinations probably are: /usr/share/ansible_plugins/
I'm sure we could improve the RPM requires for this package. I think the idea is to install the openshift-ansible package and it for to pull in all the dependencies.
I suspect that the default lookup path for lookup_plugins and filter_plugins is what is making things work even with these symlinks being broken. We might just need to exclude these symlinks from the packaging.
Troy, I don't think we're going to merge this until after other blockers are done but if you want to take a look check this out: https://github.com/openshift/openshift-ansible/pull/1823
This is just the tip of the problem. There are 20 broken links pointing to filter_plugins and 16 pointing to lookup_plugins. If you are certain that we are find getting rid of these, I can get you a nice find command that will clean them all up.
That sounds good to me. Feel free to just put it in a PR that can replace mine. I think all the broken symlinks need to be removed. I suspect they are only there because they aren't broken from a git clone and are a workaround for development.
How does this look https://github.com/openshift/openshift-ansible/pull/1827
Commit pushed to master at https://github.com/openshift/openshift-ansible https://github.com/openshift/openshift-ansible/commit/a99b49fb93f1edc4a1c68c472c059e3ed0c91b6b Merge pull request #1827 from tdawson/201604-broken-symlinks Bug 1330091 - cleanup broken symlinks - lookup_plugins filter_plugins
The pull request to fix this bug has been merged. This is going into the 3.3 installer. Updating bugzilla appropriately.
Verify this bug with openshift-ansible-playbooks-3.3.2-1.git.0.1223e95.el7.noarch After package installed, no such broken symlinks any more. [root@host-192-168-0-68 ~]# ls -al /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins ls: cannot access /usr/share/ansible/openshift-ansible/playbooks/byo/filter_plugins: No such file or directory [root@host-192-168-0-68 ~]# ls -al /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins ls: cannot access /usr/share/ansible/openshift-ansible/playbooks/byo/lookup_plugins: No such file or directory
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1933