Bug 1330276 - Rawhide live image compose fails: AttributeError: 'NoneType' object has no attribute 'format'
Summary: Rawhide live image compose fails: AttributeError: 'NoneType' object has no at...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F25AlphaBlocker
TreeView+ depends on / blocked
 
Reported: 2016-04-25 18:53 UTC by Adam Williamson
Modified: 2016-06-01 14:02 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-01 14:02:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2016-04-25 18:53:50 UTC
All Rawhide live image compose tasks currently fail with an anaconda crash. e.g. today's Workstation live:

http://koji.fedoraproject.org/koji/taskinfo?taskID=13790502
https://kojipkgs.fedoraproject.org//work/tasks/502/13790502/anaconda.log

07:43:30,658 CRIT anaconda: Traceback (most recent call last):

  File "/usr/lib/python3.5/site-packages/pyanaconda/ui/tui/simpleline/base.py", line 346, in _mainloop
    prompt = last_screen.prompt(self._screens[-1][1])

  File "/usr/lib/python3.5/site-packages/pyanaconda/ui/tui/hubs/summary.py", line 79, in prompt
    if self._checker and not self._checker.check():

  File "/usr/lib/python3.5/site-packages/pyanaconda/ui/lib/space.py", line 112, in check
    dev_required_size = self.payload.requiredDeviceSize(self.storage.root_device.format)

AttributeError: 'NoneType' object has no attribute 'format'

that check was changed slightly with the Blivet 2.0 migration:

https://github.com/rhinstaller/anaconda/commit/687d71647369c9a936670821ec504fa9b1c3a21f#diff-8fc9a5b13503c00fc8f0d7753f6c091c

the previous version of the code has been there since 91785fb1 on 2015-10-23. It seems we last got a successful Rawhide live image build on 2016-03-29, so this *does* match the Blivet 2.0 migration - anaconda 25.5 landed in Rawhide on 2016-03-30: http://koji.fedoraproject.org/koji/buildinfo?buildID=750041

This is an automatic F25 Alpha blocker as it prevents compose of several release-blocking images.

Comment 1 Adam Williamson 2016-05-07 04:56:34 UTC
This seems to have been fixed, at least we got lives for Rawhide-20160506.n.1...was there a change to address this?

Comment 2 Jiri Konecny 2016-06-01 12:54:25 UTC
Hello Adam,

I tried to found the commit which fixed this issue but there are so many changes between these commits and I can't find logs from the failed builds to have another lead. So it's hard to say if that was fixed by blivet change or anaconda change or something else.

It could be by Blivet 2.0. There were many commits fixing the API change and similar problems.

I don't know why this happened but I think if it is OK for a newer builds it seems it's fixed already and this could be close.

Comment 3 Adam Williamson 2016-06-01 14:02:38 UTC
welp, we're definitely getting lives in Rawhide composes now, so let's call it good.


Note You need to log in before you can comment on or make changes to this bug.