Bug 1330552 – [RFE] Don't allow editing NIC configurations if they are unmanaged/NM_CONTROLLED=no

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1330552 - [RFE] Don't allow editing NIC configurations if they are unmanaged/NM_CONTROLLED=no

Summary:	[RFE] Don't allow editing NIC configurations if they are unmanaged/NM_CONTROL...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	cockpit (Show other bugs)
Sub Component:
Version:	7.2
Hardware:	Unspecified Unspecified

Priority	urgent Severity unspecified
Target Milestone:	rc
Target Release:	7.2
Assigned To:	Dominik Perpeet
QA Contact:	Jan Ščotka
Docs Contact:

URL:	https://github.com/cockpit-project/co...
Whiteboard:
Keywords:	Extras, FutureFeature

Depends On:
Blocks:	ovirt-node-ng-platform
	Show dependency tree / graph

Reported:	2016-04-26 08:39 EDT by Fabian Deutsch
Modified:	2016-08-05 05:12 EDT (History)
CC List:	2 users (show)

See Also:
Fixed In Version:	cockpit-0.114-2
Doc Type:	Enhancement
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-08-04 09:47:22 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:1442	normal	SHIPPED_LIVE	cockpit bug fix and enhancement update	2016-08-04 13:45:50 EDT

Groups: None (edit)

Description Fabian Deutsch 2016-04-26 08:39:31 EDT

Description of problem:
NICs can be configured to be not managed by NM by adding NM_CONTROLLED=no to the ifcfg-* file.
Those NICs will appear as "unmanaged" in "nmcli d".

Cockpit should prevent that a user can edit these NICs.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Marius Vollmer 2016-04-28 04:52:54 EDT

See https://github.com/cockpit-project/cockpit/issues/1308

Comment 4 Stef Walter 2016-05-25 02:52:54 EDT

Marius, this is an important bug for RHEV-H use of Cockpit. Did you already have a patch for making this work?

Comment 5 Stef Walter 2016-06-23 09:28:06 EDT

Haven't heard from Marius. I think I have a patch.

Comment 6 Stef Walter 2016-06-23 10:24:52 EDT

https://github.com/cockpit-project/cockpit/pull/4627

Comment 7 Stef Walter 2016-06-24 04:15:24 EDT

Will be included in Cockpit upstream 0.112, and included in RHEL during the next update. I'm not updating FixedInVersion or setting MODIFIED until we know that it's inlcuded in a RHEL release.

Comment 9 Stef Walter 2016-07-14 08:22:15 EDT

Cockpit integration test here: https://github.com/cockpit-project/cockpit/blob/master/test/verify/check-networking#L181

Comment 12 errata-xmlrpc 2016-08-04 09:47:22 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1442.html

Note You need to log in before you can comment on or make changes to this bug.