Bug 1330595 - /usr/bin/docker wrapper script: $@ must be quoted
Summary: /usr/bin/docker wrapper script: $@ must be quoted
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: docker
Version: 7.2
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: rc
: ---
Assignee: Lokesh Mandvekar
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-26 14:26 UTC by Ed Santiago
Modified: 2019-03-06 01:20 UTC (History)
3 users (show)

Fixed In Version: docker-1.9.1-34.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-12 15:18:24 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:1034 0 normal SHIPPED_LIVE Moderate: docker security, bug fix, and enhancement update 2016-05-12 19:15:01 UTC

Description Ed Santiago 2016-04-26 14:26:02 UTC
docker-common-1.9.1-33.el7 introduces /usr/bin/docker as a wrapper script that selects between docker-current and docker-latest. The exec line currently reads:

   exec ${DOCKERBINARY} $@

The $@ is missing double quotes. It should be: "$@" (double-quote, dollar, at, double-quote). See 'Special Parameters' in bash(1) for really-kind-of-inadequate explanation, but basically, without the double-quotes, you lose information about individual params and/or spaces within params.

Comment 1 Lokesh Mandvekar 2016-04-26 14:43:52 UTC
fix upcoming ...

Comment 2 Daniel Walsh 2016-04-26 14:56:13 UTC
Lokesh can you handle the situation where docker-latest is installed but docker is not?  Or does docker-latest require docker?

Comment 3 Lokesh Mandvekar 2016-04-26 15:01:19 UTC
docker-latest does require docker-common and people could edit /etc/sysconfig/docker to point it to /usr/bin/docker-latest, or do you want this pointing to /usr/bin/docker-latest to be automatic if we only have docker-common and docker-latest installed?

Comment 4 Daniel Walsh 2016-04-26 17:06:43 UTC
Well docker command will fail if there is nothing set in /etc/sysconfig/docker.  Which might be fine, but we should enhance the script to point this out as an error. Or for now make the script look for /usr/bin/docker-common followed by searching for /usr/bin/docker-latest.

We still have an /etc/sysconfig/docker-latest, correct?

Comment 5 Lokesh Mandvekar 2016-04-26 17:12:25 UTC

(In reply to Daniel Walsh from comment #4)
> Well docker command will fail if there is nothing set in
> /etc/sysconfig/docker.  Which might be fine, but we should enhance the
> script to point this out as an error. Or for now make the script look for
> /usr/bin/docker-common followed by searching for /usr/bin/docker-latest.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1330622#c4

> 
> We still have an /etc/sysconfig/docker-latest, correct?

Yes

Also, should DOCKERBINARY be set in a new /etc/sysconfig/docker-common instead, or does it suffice to have it in /etc/sysconfig/docker itself (latter means less work for me)

Comment 7 Daniel Walsh 2016-04-26 17:59:58 UTC
Just put the entry in /etc/sysconfig/docker

Comment 9 Luwen Su 2016-05-01 03:46:06 UTC
In docker-1.9.1-38.el7.x86_64
#cat /usr/bin/docker
exec ${DOCKERBINARY} "$@"

Move to verified

Comment 11 errata-xmlrpc 2016-05-12 15:18:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-1034.html


Note You need to log in before you can comment on or make changes to this bug.