Red Hat Bugzilla – Bug 1330595
/usr/bin/docker wrapper script: $@ must be quoted
Last modified: 2016-05-12 11:18:24 EDT
docker-common-1.9.1-33.el7 introduces /usr/bin/docker as a wrapper script that selects between docker-current and docker-latest. The exec line currently reads: exec ${DOCKERBINARY} $@ The $@ is missing double quotes. It should be: "$@" (double-quote, dollar, at, double-quote). See 'Special Parameters' in bash(1) for really-kind-of-inadequate explanation, but basically, without the double-quotes, you lose information about individual params and/or spaces within params.
fix upcoming ...
Lokesh can you handle the situation where docker-latest is installed but docker is not? Or does docker-latest require docker?
docker-latest does require docker-common and people could edit /etc/sysconfig/docker to point it to /usr/bin/docker-latest, or do you want this pointing to /usr/bin/docker-latest to be automatic if we only have docker-common and docker-latest installed?
Well docker command will fail if there is nothing set in /etc/sysconfig/docker. Which might be fine, but we should enhance the script to point this out as an error. Or for now make the script look for /usr/bin/docker-common followed by searching for /usr/bin/docker-latest. We still have an /etc/sysconfig/docker-latest, correct?
(In reply to Daniel Walsh from comment #4) > Well docker command will fail if there is nothing set in > /etc/sysconfig/docker. Which might be fine, but we should enhance the > script to point this out as an error. Or for now make the script look for > /usr/bin/docker-common followed by searching for /usr/bin/docker-latest. See: https://bugzilla.redhat.com/show_bug.cgi?id=1330622#c4 > > We still have an /etc/sysconfig/docker-latest, correct? Yes Also, should DOCKERBINARY be set in a new /etc/sysconfig/docker-common instead, or does it suffice to have it in /etc/sysconfig/docker itself (latter means less work for me)
Just put the entry in /etc/sysconfig/docker
In docker-1.9.1-38.el7.x86_64 #cat /usr/bin/docker exec ${DOCKERBINARY} "$@" Move to verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-1034.html