Bug 1330616 - Minor improvements and code cleanup for libglusterfs
Summary: Minor improvements and code cleanup for libglusterfs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: All
OS: All
low
low
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-26 14:57 UTC by Anoop C S
Modified: 2016-06-16 14:04 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-16 14:04:45 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anoop C S 2016-04-26 14:57:22 UTC
Description of problem:

Use this bug to file changes that affect source files under libglusterfs/ directory. Real bugs (problem reports, crashes) should have their own bugzilla entry for related patches.

Acceptable changes include:
    -Improve code readability
    -Remove dead code
    -Better error reporting
    - . . .

Comment 1 Vijay Bellur 2016-04-26 15:31:31 UTC
REVIEW: http://review.gluster.org/14083 (Rename enum _gf_client_pid to _gf_special_pid) posted (#1) for review on master by Anoop C S (anoopcs)

Comment 2 Vijay Bellur 2016-04-27 12:36:11 UTC
COMMIT: http://review.gluster.org/14083 committed in master by Jeff Darcy (jdarcy) 
------
commit 2a6c6de35130328cfb6f95a6d7794dcb01b4004d
Author: Anoop C S <anoopcs>
Date:   Tue Apr 26 19:49:34 2016 +0530

    Rename enum _gf_client_pid to _gf_special_pid
    
    Till now _gf_client_pid enum has been used to define special PIDs used
    by glusterfs clients like shd, quotad etc. In order to have this enum
    capable of holding all other special PIDs including the one used by
    trash translator, _gf_client_pid is being renamed to _gf_special_pid.
    
    Change-Id: Id123127771f18aa55d39f335801a54810848d7bc
    BUG: 1330616
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/14083
    Reviewed-by: Joseph Fernandes
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 3 Niels de Vos 2016-06-16 14:04:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.