Bug 1330620 - HTTP_PROXY, HTTPS_PROXY, and NO_PROXY set to null values
Summary: HTTP_PROXY, HTTPS_PROXY, and NO_PROXY set to null values
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: ---
Assignee: Scott Dodson
QA Contact: Gan Huang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-26 15:08 UTC by Scott Dodson
Modified: 2016-05-30 08:24 UTC (History)
5 users (show)

Fixed In Version: openshift-ansible-3.0.86-1.git.0.e221ac1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-12 16:40:58 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1065 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise atomic-openshift-utils bug fix update 2016-05-12 20:32:56 UTC

Description Scott Dodson 2016-04-26 15:08:42 UTC
Description of problem:
If proxy settings aren't defined then we shouldn't add the environment variables to /etc/sysconfig/docker and /etc/atomic-openshift-master


Version-Release number of selected component (if applicable):
current

How reproducible:


Steps to Reproduce:
1. run installer without setting openshift_http_proxyor openshift_https_proxy
2.
3.

Actual results:
HTTP_PROXY=''
HTTPS_PROXY=''
NO_PROXY='' 
in /etc/sysconfig/docker and /etc/sysconfig/atomic-openshift-master

Expected results:
No HTTP_PROXY, HTTPS_PROXY, NO_PROXY variables in the above files.

Additional info:

Comment 1 Scott Dodson 2016-04-26 15:09:36 UTC
Proposed fix https://github.com/openshift/openshift-ansible/pull/1808

Comment 3 Gan Huang 2016-04-27 07:17:57 UTC
Test aganist openshift-ansible-3.0.86-1.git.0.e221ac1.el7 

Proxy settings were gone in node, master, docker configuration when no proxy was defined in inventory hosts file.

Will verify again once pushed to puddle.

Comment 4 Gan Huang 2016-04-28 03:10:34 UTC
Verified with openshift-ansible-3.0.87-1.git.0.7f67d5d.el7.noarch

Move it to verified.

Comment 6 errata-xmlrpc 2016-05-12 16:40:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1065


Note You need to log in before you can comment on or make changes to this bug.