Bug 1330934 - [Behind Proxy] The variable of "openshift_generate_no_proxy_hosts" doesn't work
Summary: [Behind Proxy] The variable of "openshift_generate_no_proxy_hosts" doesn't work
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: ---
Assignee: Scott Dodson
QA Contact: Ma xiaoqiang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-27 10:45 UTC by Gan Huang
Modified: 2017-01-22 02:48 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Consequence: openshift-ansible did not properly convert the openshift_generate_no_proxy_hosts to a boolean so it may have been ignored. Fix: openshift_generate_no_proxy_hosts is now properly converted into a boolean ensuring that this variable produces the desired effect.
Clone Of:
Environment:
Last Closed: 2016-06-07 10:55:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1208 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise atomic-openshift-utils bug fix update 2016-06-07 14:55:01 UTC

Description Gan Huang 2016-04-27 10:45:53 UTC
Description of problem:
When set "openshift_generate_no_proxy_hosts=False" in inventory hosts file, openshift masters, nodes, and etcd hosts would be still included in "NO_PROXY".

Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.0.86-1.git.0.e221ac1.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. Set "openshift_generate_no_proxy_hosts=False" in inventory hosts file
2. Set "openshift_no_proxy='test.local'" in inventory hosts file
2. Run "ansible-playbook -i hosts  /usr/share/ansible/openshift-ansible/playbooks/byo/config.yml"


Actual results:
Check the variable of NO_PROXY in master,docker configuration.
<--snip-->
NO_PROXY='.cluster.local,host-x-172-76.redhat.com,host-x-172-89.redhat.com,test.local'

Expected results:
Don't add those hostnames to the openshift_no_proxy list when set "openshift_generate_no_proxy_hosts=False"

Additional info:

Comment 1 Scott Dodson 2016-04-27 17:47:40 UTC
Proposed fix https://github.com/openshift/openshift-ansible/pull/1828

Comment 3 Gan Huang 2016-05-18 09:54:14 UTC
Verified with openshift-ansible-3.0.90-1.git.0.a077b68.el7.noarch

* openshift_generate_no_proxy_hosts=False, openshift_no_proxy='test.local'
test.local and the host itself were set in NO_PROXY


* openshift_generate_no_proxy_hosts=False, don't set openshift_no_proxy
the host itself were set in NO_PROXY

I agree with this kind of set as it's safer. So move it to verified.

Comment 5 errata-xmlrpc 2016-06-07 10:55:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1208


Note You need to log in before you can comment on or make changes to this bug.