1331328 – libvirt does not report PCI_HEADER_TYPE in node device XML

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1331328 - libvirt does not report PCI_HEADER_TYPE in node device XML

Summary: libvirt does not report PCI_HEADER_TYPE in node device XML

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libvirt
Sub Component:
Version:	7.2
Hardware:	Unspecified
OS:	Unspecified
Priority:	high
Severity:	urgent
Target Milestone:	rc
Target Release:	---
Assignee:	Michal Privoznik
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:	1317531
Blocks:
TreeView+	depends on / blocked

Reported:	2016-04-28 10:13 UTC by Marcel Kolaja
Modified:	2016-06-23 06:12 UTC (History)
CC List:	15 users (show)
Fixed In Version:	libvirt-1.2.17-13.el7_2.5
Doc Type:	Bug Fix
Doc Text:	Previously, the node device XML did not contain the PCI header type, which caused guest PCI devices to be unavailable for passthrough assignment. With this update, the libvirt service reports the PCI header type properly, and guest PCI devices can be assigned for passthrough as expected.
Clone Of:	1317531
Environment:
Last Closed:	2016-06-23 06:12:26 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:1290	0	normal	SHIPPED_LIVE	libvirt bug fix update	2016-07-01 18:50:44 UTC

Description Marcel Kolaja 2016-04-28 10:13:14 UTC

This bug has been copied from bug #1317531 and has been proposed
to be backported to 7.2 z-stream (EUS).

Comment 4 Martin Kletzander 2016-04-28 14:11:32 UTC

Moving to POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2016-April/msg00409.html

Comment 6 Michal Privoznik 2016-05-19 13:46:18 UTC

v2:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2016-May/msg00172.html

Comment 7 Jiri Denemark 2016-05-20 06:42:34 UTC

Moving back to ASSIGNED based on review results.

Comment 8 Michal Privoznik 2016-05-24 05:40:47 UTC

Moving back to POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2016-May/msg00216.html

Comment 10 Jingjing Shao 2016-05-27 07:48:11 UTC

For the XML of endpoints should not change, for bridge ,it should add the header type as the right part and the cardbus-bridge testing needs special hardware with cardbus-bridge，for now we can not get the suitable system


Verified the bug as below with libvirt-1.2.17-13.el7_2.5.x86_64

1.[root@ibm-x3850x5-05 jishao]# virsh nodedev-list --tree
  +- pci_0000_80_01_0
  |   |
  |   +- pci_0000_86_00_0
  |   |   |
  |   |   +- net_eth2_90_e2_ba_30_79_5c
  |   |     
  |   +- pci_0000_86_00_1
  |   |   |
  |   |   +- net_eth5_90_e2_ba_30_79_5d
  |   |     
  |   +- pci_0000_86_10_0
  |   |   |
  |   |   +- net_eth6_a6_59_70_2b_bb_62
  |   |     
  |   +- pci_0000_86_10_1
  |   |   |
  |   |   +- net_eth3_f2_4a_b4_81_32_9a

2. [root@ibm-x3850x5-05 jishao]#  lspci -vv
80:01.0 PCI bridge: Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port 1 (rev 22) (prog-if 00 [Normal decode])
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR- FastB2B- DisINTx+
....
Capabilities: [90] Express (v2) Root Port (Slot+), MSI 00
......

86:00.0 Ethernet controller: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01)
.....
Capabilities: [a0] Express (v2) Endpoint, MSI 00
......

86:10.0 Ethernet controller: Intel Corporation 82599 Ethernet Controller Virtual Function (rev 01)
....
Capabilities: [a0] Express (v0) Endpoint, MSI 00
.....

3.[root@ibm-x3850x5-05 jishao]# virsh nodedev-dumpxml pci_0000_80_01_0
<device>
  <name>pci_0000_80_01_0</name>
  <path>/sys/devices/pci0000:80/0000:80:01.0</path>
  <parent>computer</parent>
  <driver>
    <name>pcieport</name>
  </driver>
  <capability type='pci'>
    <domain>0</domain>
    <bus>128</bus>
    <slot>1</slot>
    <function>0</function>
    <product id='0x3408'>5520/5500/X58 I/O Hub PCI Express Root Port 1</product>
    <vendor id='0x8086'>Intel Corporation</vendor>
    <iommuGroup number='19'>
      <address domain='0x0000' bus='0x80' slot='0x01' function='0x0'/>
    </iommuGroup>
    <numa node='1'/>
    <capability type='pci-bridge'/>   <===========add the pci header type
    <pci-express>
      <link validity='cap' port='1' speed='5' width='4'/>
      <link validity='sta' speed='5' width='4'/>
    </pci-express>
  </capability>
</device>

[root@ibm-x3850x5-05 jishao]# virsh nodedev-dumpxml pci_0000_86_00_0
<device>
  <name>pci_0000_86_00_0</name>
  <path>/sys/devices/pci0000:80/0000:80:01.0/0000:86:00.0</path>
  <parent>pci_0000_80_01_0</parent>
  <driver>
    <name>ixgbe</name>
  </driver>
  <capability type='pci'>
    <domain>0</domain>
    <bus>134</bus>
    <slot>0</slot>
    <function>0</function>
    <product id='0x10fb'>82599ES 10-Gigabit SFI/SFP+ Network Connection</product>
    <vendor id='0x8086'>Intel Corporation</vendor>
    <capability type='virt_functions'>
      <address domain='0x0000' bus='0x86' slot='0x10' function='0x0'/>
      <address domain='0x0000' bus='0x86' slot='0x10' function='0x2'/>
    </capability>
    <iommuGroup number='27'>
      <address domain='0x0000' bus='0x86' slot='0x00' function='0x0'/>
    </iommuGroup>
    <numa node='1'/>      <===========can not find the pci header type                
    <pci-express>
      <link validity='cap' port='0' speed='5' width='8'/>
      <link validity='sta' speed='5' width='4'/>
    </pci-express>
  </capability>
</device>

[root@ibm-x3850x5-05 jishao]# virsh nodedev-dumpxml pci_0000_86_10_0
<device>
  <name>pci_0000_86_10_0</name>
  <path>/sys/devices/pci0000:80/0000:80:01.0/0000:86:10.0</path>
  <parent>pci_0000_80_01_0</parent>
  <driver>
    <name>ixgbevf</name>
  </driver>
  <capability type='pci'>
    <domain>0</domain>
    <bus>134</bus>
    <slot>16</slot>
    <function>0</function>
    <product id='0x10ed'>82599 Ethernet Controller Virtual Function</product>
    <vendor id='0x8086'>Intel Corporation</vendor>
    <capability type='phys_function'>
      <address domain='0x0000' bus='0x86' slot='0x00' function='0x0'/>
    </capability>
    <iommuGroup number='81'>
      <address domain='0x0000' bus='0x86' slot='0x10' function='0x0'/>
    </iommuGroup>
    <numa node='1'/>       <===========can not find the pci header 
    <pci-express> 
      <link validity='cap' port='0' width='0'/>
      <link validity='sta' width='0'/>
    </pci-express>
  </capability>
</device>

Comment 12 errata-xmlrpc 2016-06-23 06:12:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1290

Note You need to log in before you can comment on or make changes to this bug.