Bug 1331365 - [quick install] [Behind Proxy] Proxy settings should be more fridenly
Summary: [quick install] [Behind Proxy] Proxy settings should be more fridenly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: ---
Assignee: Samuel Munilla
QA Contact: Ma xiaoqiang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-28 11:43 UTC by Gan Huang
Modified: 2017-01-22 02:48 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-07 10:55:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1208 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise atomic-openshift-utils bug fix update 2016-06-07 14:55:01 UTC

Description Gan Huang 2016-04-28 11:43:31 UTC
Description of problem:
quick-installer confuses users on three points.
1.According to https://github.com/openshift/openshift-ansible/blob/master/inventory/byo/hosts.ose.example, proxy can be set to "http://USER:PASSWORD@IPADDR:PORT". But it semms only support hostname as proxy when prompting following messages:
Specify the hostname for your proxy? (ENTER for none) []

2.It doesn't make a distinction between https and http proxy. It's better to spilt proxy to http proxy and https proxy in case they are the diffenent settings.

3.As "openshift_generate_no_proxy_hosts=True" by default, all the installing node will be added into no_proxy host list automatically, but in quick installer, it only prompt this:
List any hosts that should be excluded from your proxy. (ENTER for none) []:
Then user will be easy to input all the installing nodes entry again, that would lead to the no_proxy host list will have dupulicated node host, so the prompt should be more clear, saying all the installating node is already be excluded from your proxy.

Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.0.87-1.git.0.7f67d5d.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
For 1 and 2:

Specify your http proxy ? (ENTER for none) []: 

Specify your https proxy ? (ENTER for none) []:

For 3:
Note: The installed hosts will be excluded from your proxy automatically.

List any hosts that should be excluded from your proxy. (ENTER for none) []:
Additional info:

Comment 1 Scott Dodson 2016-04-28 17:58:00 UTC
Gan,

I think disabling the generation should be an advance installer only item, the vast majority of installs will need this set to True. If anything perhaps we should change the question to be something like this

All hosts in your openshift inventory will automatically be added to the NO_PROXY value. Please provide any additional hosts to be added to NO_PROXY. (ENTER for none) []:

Comment 2 Gan Huang 2016-04-29 02:17:50 UTC
(In reply to Scott Dodson from comment #1)
> Gan,
> 
> I think disabling the generation should be an advance installer only item,
> the vast majority of installs will need this set to True. If anything
> perhaps we should change the question to be something like this
> 
Yes, you're right. I also don't want the variable (openshift_generate_no_proxy_hosts) to be configured in quick-installer. Sorry for my unclear description.

> All hosts in your openshift inventory will automatically be added to the
> NO_PROXY value. Please provide any additional hosts to be added to NO_PROXY.
> (ENTER for none) []:

Fully agree! That's my original thoughts.

Comment 3 Gan Huang 2016-05-10 07:23:01 UTC
Sorry, this fix hasn't been packaged in atomic-openshift-utils yet. Please assign to me once committed to package atomic-openshift-utils.

Comment 4 Samuel Munilla 2016-05-10 13:21:31 UTC
My mistake. https://github.com/openshift/openshift-ansible/pull/1836 is the PR that handles it.

Comment 6 Gan Huang 2016-05-16 10:26:24 UTC
Test aganist atomic-openshift-utils-3.0.89-1.git.64.2356e54.el7.noarch

"ENTER for none" seems not correct for https proxy as the default is "test.local":

Specify your http proxy ? (ENTER for none) []: test.local
Specify your https proxy ? (ENTER for none) [test.local]: 


So the minor issue is that it should remove "(ENTER for none)" when asked to "Specify your https proxy ?". Others look good to me. :)

Comment 7 Gan Huang 2016-05-19 06:20:49 UTC
It has no changes about what I mentioned above. I'wll move it verified first as it's a minor issue.

Verified with atomic-openshift-utils-3.0.90-1.git.0.a077b68.el7.noarch

Comment 9 errata-xmlrpc 2016-06-07 10:55:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1208


Note You need to log in before you can comment on or make changes to this bug.