RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1331629 - `INPLACERISK: NONE: foo` does not really make any sense
Summary: `INPLACERISK: NONE: foo` does not really make any sense
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: preupgrade-assistant
Version: 6.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Petr Hracek
QA Contact: Alois Mahdal
URL:
Whiteboard:
Depends On:
Blocks: 1335121
TreeView+ depends on / blocked
 
Reported: 2016-04-29 05:48 UTC by Alois Mahdal
Modified: 2016-11-04 08:57 UTC (History)
6 users (show)

Fixed In Version: preupgrade-assistant-2.1.8-4.el6
Doc Type: Bug Fix
Doc Text:
If there is no risk detected, the Preupgrade Assistant no longer writes logs and returns an info message instead.
Clone Of:
Environment:
Last Closed: 2016-11-04 08:57:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2616 0 normal SHIPPED_LIVE preupgrade-assistant bug fix and enhancement update 2016-11-03 16:23:38 UTC

Description Alois Mahdal 2016-04-29 05:48:15 UTC
Description of problem
======================

log_none_risk() does not make sense.  If you want to log a risk, you
log a risk because there is one, of certain "risk level".  But there's
no such thing as "no risk level" as long as there is a risk.

Also, the effect of using such function is confusing in the report:

    INPLACERISK: NONE: Blah blah...

Is this a risk or not?

Let's stop messing with people's heads.  Including our own:  if we agree
"it should log risk" does this count?

Comment 2 Ondrej Vasik 2016-04-29 20:01:31 UTC
I partially agree. Originally, this risk level was supposed to indicate what was checked - and basically saying "Ok, this seems to be safe". However, this was based on assumption we will have some separate report of risks. Nowadays, just info message should be enough and much less confusing. Therefore ack for devel side.

Comment 3 Ondrej Vasik 2016-04-30 07:14:51 UTC
Moving to Petr, however, it would require checking all scripts for existance of "none" risk usage.

Comment 6 Alois Mahdal 2016-07-20 15:07:17 UTC
(In reply to Ondrej Vasik from comment #3)
> Moving to Petr, however, it would require checking all scripts for existance
> of "none" risk usage.

JFTR; bug 1356057 is the one to track removal of NONE usage from modules.

Comment 7 Alois Mahdal 2016-07-29 23:37:13 UTC
Not removed; still present in

 *  common.sh (Bash API)

 *  tests (created "manually" using echo),

 *  more places:

        @fullmoon|work:~/vcs.ipu/preupgrade-assistant((2.1.8))$ grep _none_ -r
        common.sh:303:log_none_risk() {
        preuputils/xml_utils.py:179:        check_func = {'log_': ['log_none_risk', 'log_slight_risk',
        @fullmoon|work:~/vcs.ipu/preupgrade-assistant((2.1.8))$ grep NONE -r
        tests/FOOBAR6_7/dummy/needs_inspection/dummy_failed.sh:5:echo "INPLACERISK: NONE: This is None Risk"
        tests/FOOBAR6_7/dummy/needs_inspection/solution.txt:3:INPLACERISK: NONE: None inplace risk
        tests/test_inplace_risks.py:87:        temp_file = self._copy_xccdf_file(b'INPLACERISK: NONE: Test None Inplace risk')
        common.sh:307:    log_risk "NONE" "$1"
        preup/cli.py:103:                 "0 ... NONE, SLIGHT risks were detected." + "\n" * 20 +
        preup/xccdf.py:28:            'NONE:': 0,
        preup/report_parser.py:40:        of NONE, SLIGHT or MEDIUM risk
        preup/report_parser.py:222:        NEEDS_INSPECTION in case that risks are NONE or SLIGHT
        man/preupg.1:58:Return values are 0 for NONE, SLIGHT risks or 1 for MEDIUM, HIGH risks or 2 for EXTREME risk.
        preup_ui/xmlrpc_backend/views.py:53:  <meta name="robots" content="NONE,NOARCHIVE" />
        @fullmoon|work:~/vcs.ipu/preupgrade-assistant((2.1.8))$ 

    (not all places are necessarily be relevant but you get the point)

Comment 10 Alois Mahdal 2016-08-30 21:14:38 UTC
preupgrade-assistant-2.1.9-1.el6:  this time it's wiped out properly. :)

(Also from modules, as tracked by bug 1356057)

(Well, except it's still mentioned in one note in the manpage, but since the manpage is so obsolete and incomplete it's ready for rewrite, that should not block us.)

Comment 12 errata-xmlrpc 2016-11-04 08:57:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2616.html


Note You need to log in before you can comment on or make changes to this bug.