Bug 1331756 - OSD's which are in "Down" State are also getting considered while reweight-by-utilization
Summary: OSD's which are in "Down" State are also getting considered while reweight-by...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: RADOS
Version: 1.3.2
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: rc
: 2.0
Assignee: Sage Weil
QA Contact: ceph-qe-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-29 12:48 UTC by Tanay Ganguly
Modified: 2017-07-30 15:17 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-02 19:24:24 UTC
Embargoed:

Attachments (Terms of Use)
Steps (5.06 KB, text/plain)
2016-04-29 12:48 UTC, Tanay Ganguly 		no flags Details
View All

Description Tanay Ganguly 2016-04-29 12:48:50 UTC 
Created attachment 1152279 [details]
Steps

Description of problem:
OSD's which are in "Down" State are also getting considered while reweight-by-utilization.

Version-Release number of selected component (if applicable):
ceph version 0.94.5-6redhat1trusty

How reproducible:
Always

Steps to Reproduce:
1. Mark 1 OSD down.
2. Immediately start the reweight-by-utilization, with the value which satisfies the "Down" OSD condition.

e.g. Down OSD 
 0 0.89999  0.80005   926G  782G  143G 84.50 1.10

 sudo ceph osd test-reweight-by-utilization 108 .05 4

Actual results:
"Down" OSD is also considered while reweighting

Expected results:
"Down" OSD should not be considered for reweight.

Additional info:
PFA, Detailed Steps
Comment 2 Samuel Just 2016-04-29 14:49:00 UTC 
So it should factor them into the average, but not reweight them?
Comment 3 Sage Weil 2016-04-29 20:29:51 UTC 
It feels like we should consider all non-out OSDs, regardless of whether they are up or down, since up/down is normally transient.
Comment 4 Neil Levine 2016-05-02 19:24:24 UTC 
Agreed.
Note You need to log in before you can comment on or make changes to this bug.