Spec URL: https://gil.fedorapeople.org/csvjdbc.spec SRPM URL: https://gil.fedorapeople.org/csvjdbc-1.0.29-1.fc23.src.rpm Description: CsvJdbc is a read-only JDBC driver that uses Comma Separated Value (CSV) files or DBF files as database tables. It is ideal for writing data import programs or analyzing log files. The driver enables a directory or a ZIP file containing CSV or DBF files to be accessed as though it were a database containing tables. However, as there is no real database management system behind the scenes, not all JDBC functionality is available. Fedora Account System Username: gil
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13858865
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== [!]: License field in the package spec file matches the actual license. One file has unknown license, or a license header is missing: src/test/java/org/relique/jdbc/csv/TestFileSetInputStream.java Ask upstream to include the missing license headers. [!]: Summary line is a bit messy I would write either "Java driver for ..." or "JDBC for ..." ===== Non-blockers ===== [!]: SourceX is a working URL. I know there's no upstream tarball, just adding this for a reference. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/makerpm/rev/csvjdbc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 204800 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Rpmlint ------- Checking: csvjdbc-1.0.29-1.fc25.noarch.rpm csvjdbc-javadoc-1.0.29-1.fc25.noarch.rpm csvjdbc-1.0.29-1.fc25.src.rpm csvjdbc.src: W: invalid-url Source0: csvjdbc-1.0.29.tar.xz 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- csvjdbc (rpmlib, GLIBC filtered): java-headless javapackages-tools csvjdbc-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- csvjdbc: csvjdbc mvn(net.sourceforge.csvjdbc:csvjdbc) mvn(net.sourceforge.csvjdbc:csvjdbc:pom:) csvjdbc-javadoc: csvjdbc-javadoc Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --rpm-spec -n csvjdbc-1.0.29-1.fc23.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Tomas Repik from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > ===== Issues ===== > > [!]: License field in the package spec file matches the actual license. > One file has unknown license, or a license header is missing: > src/test/java/org/relique/jdbc/csv/TestFileSetInputStream.java > Ask upstream to include the missing license headers. Done https://sourceforge.net/p/csvjdbc/code/ci/64040bc1ae27255799b4e75858859278a7be231c/ > [!]: Summary line is a bit messy I would write either "Java driver for ..." > or > "JDBC for ..." Done > ===== Non-blockers ===== > > [!]: SourceX is a working URL. > I know there's no upstream tarball, just adding this for a reference. Done > ===== MUST items ===== > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "LGPL (v2.1 or later)", "Unknown or generated". 2 files have > unknown license. Detailed output of licensecheck in > /home/makerpm/rev/csvjdbc/licensecheck.txt ?? Spec URL: https://gil.fedorapeople.org/csvjdbc.spec SRPM URL: https://gil.fedorapeople.org/csvjdbc-1.0.29-1.fc23.src.rpm
Well done, this package passed my review. I can do some more reviews for you, just write which ones you'd like. There are my own two requests without a reviewer if you had some time: https://bugzilla.redhat.com/show_bug.cgi?id=1329199 https://bugzilla.redhat.com/show_bug.cgi?id=1341013
thanks for the review create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/5871 https://admin.fedoraproject.org/pkgdb/package/requests/5872
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/csvjdbc
csvjdbc-1.0.29-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6256cfdabc
csvjdbc-1.0.29-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6256cfdabc
csvjdbc-1.0.29-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.