Bug 1332404 - the wrong variable was being checked for gf_strdup
Summary: the wrong variable was being checked for gf_strdup
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: rpc
Version: 3.7.11
Hardware: All
OS: All
low
low
Target Milestone: ---
Assignee: Zhou Zhengping
QA Contact:
URL:
Whiteboard:
Depends On: 1325683
Blocks: glusterfs-3.7.12
TreeView+ depends on / blocked
 
Reported: 2016-05-03 06:53 UTC by Anoop C S
Modified: 2016-06-28 12:16 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.7.12
Doc Type: Bug Fix
Doc Text:
Clone Of: 1325683
Environment:
Last Closed: 2016-06-28 11:50:25 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anoop C S 2016-05-03 06:53:23 UTC
+++ This bug was initially created as a clone of Bug #1325683 +++

in function  rpc_transport_inet_options_build :

host = gf_strdup ((char*)hostname);
if (!hostname) {
    ret = -1;
    goto out;
}

hostname should be host

--- Additional comment from Vijay Bellur on 2016-04-10 21:28:27 IST ---

REVIEW: http://review.gluster.org/13934 (rpc: check the right variable after gf_strdup) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal)

--- Additional comment from Vijay Bellur on 2016-04-11 20:26:07 IST ---

REVIEW: http://review.gluster.org/13934 (rpc: check the right variable after gf_strdup) posted (#2) for review on master by Zhou Zhengping (johnzzpcrystal)

--- Additional comment from Vijay Bellur on 2016-04-12 05:24:51 IST ---

REVIEW: http://review.gluster.org/13934 (rpc: check the right variable after gf_strdup) posted (#3) for review on master by Zhou Zhengping (johnzzpcrystal)

--- Additional comment from Vijay Bellur on 2016-04-14 18:21:54 IST ---

COMMIT: http://review.gluster.org/13934 committed in master by Jeff Darcy (jdarcy) 
------
commit 1c9c776352c60deeda51be66fda6d44bf06d3796
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Sun Apr 10 23:56:17 2016 +0800

    rpc: check the right variable after gf_strdup
    
    Change-Id: If4628bd37f2c85a070f6c3b3e0583d939100d7ec
    BUG: 1325683
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: http://review.gluster.org/13934
    Smoke: Gluster Build System <jenkins.com>
    Tested-by: Jeff Darcy <jdarcy>
    Reviewed-by: Anoop C S <anoopcs>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-05-23 06:50:25 UTC
REVIEW: http://review.gluster.org/14494 (rpc: check the right variable after gf_strdup) posted (#1) for review on release-3.7 by Anoop C S (anoopcs)

Comment 2 Vijay Bellur 2016-05-27 09:07:15 UTC
COMMIT: http://review.gluster.org/14494 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 1b44116337b9ef59c2286b88e0b90d596caab270
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Sun Apr 10 23:56:17 2016 +0800

    rpc: check the right variable after gf_strdup
    
    > Reviewed-on: http://review.gluster.org/13934
    > Smoke: Gluster Build System <jenkins.com>
    > Tested-by: Jeff Darcy <jdarcy>
    > Reviewed-by: Anoop C S <anoopcs>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Vijay Bellur <vbellur>
    > CentOS-regression: Gluster Build System <jenkins.com>
    
    (cherry picked from commit 1c9c776352c60deeda51be66fda6d44bf06d3796)
    
    Change-Id: If4628bd37f2c85a070f6c3b3e0583d939100d7ec
    BUG: 1332404
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: http://review.gluster.org/14494
    Smoke: Gluster Build System <jenkins.com>
    Tested-by: Anoop C S <anoopcs>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2016-06-28 12:16:31 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.