Bug 1332545 - Add missing access keys.
Summary: Add missing access keys.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virt-viewer
Version: 7.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jonathon Jongsma
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 1340906 1351890
TreeView+ depends on / blocked
 
Reported: 2016-05-03 12:56 UTC by Andrei Stepanov
Modified: 2016-11-04 01:18 UTC (History)
12 users (show)

Fixed In Version: virt-viewer-2.0-8.el7
Doc Type: Bug Fix
Doc Text:
Cause: Some labels in ui don't have accelerators Consequence: It is not possible to navigate through menus in ui only by using the keyboard (it is needed to use mouse) Fix: Added accelerators to labels Result: It is possible to navigate through ui menus using keyboard accelerators
Clone Of:
: 1340906 1351890 (view as bug list)
Environment:
Last Closed: 2016-11-04 01:18:59 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2229 0 normal SHIPPED_LIVE virt-viewer, libgovirt, spice-gtk, and usbredir bug fix and enhancement update 2016-11-03 13:26:58 UTC

Description Andrei Stepanov 2016-05-03 12:56:55 UTC
virt-viewer-2.0-7.el7.x86_64

Remote-viewer has a lack of a few access keys.

Access keys are used to navigate through RV menu: ALT+<x>,<y>

Missing access keys are:

File->Screenshot
View->Full Screen
View->Displays
Send Keys->Ctrl+Alt+F11
Send Keys->Ctrl+Alt+F12
Send Keys->PrintScreen

Comment 2 Jonathon Jongsma 2016-05-03 20:35:28 UTC
(In reply to Andrei Stepanov from comment #0)

> Send Keys->Ctrl+Alt+F11
> Send Keys->Ctrl+Alt+F12

There aren't really any good options for mnemonic access keys for these ones.

> Send Keys->PrintScreen

This already has a "P" mnemonic access key for me.

Comment 7 Andrei Stepanov 2016-05-30 16:23:29 UTC
Pavel Grunt: Commit https://git.fedorahosted.org/cgit/virt-viewer.git/commit/?id=b917969f75565bd02a690c371dc199df8cb126b7  doesn't fix "Display N" menuitems:

https://git.fedorahosted.org/cgit/virt-viewer.git/tree/src/virt-viewer-app.c?id=b917969f75565bd02a690c371dc199df8cb126b7#n2289

User doesn't have an access to "Display N" menu-entry with accelerators.

Accelerators are keyboard shortcuts for activating a menu item.

Comment 8 Pavel Grunt 2016-05-30 17:35:13 UTC
(In reply to Andrei Stepanov from comment #7)
> Pavel Grunt: Commit
> https://git.fedorahosted.org/cgit/virt-viewer.git/commit/
> ?id=b917969f75565bd02a690c371dc199df8cb126b7  doesn't fix "Display N"
> menuitems:
> 
> https://git.fedorahosted.org/cgit/virt-viewer.git/tree/src/virt-viewer-app.
> c?id=b917969f75565bd02a690c371dc199df8cb126b7#n2289
> 
> User doesn't have an access to "Display N" menu-entry with accelerators.
> 
> Accelerators are keyboard shortcuts for activating a menu item.

Thanks for noticing, https://www.redhat.com/archives/virt-tools-list/2016-May/msg00106.html

Comment 9 Pavel Grunt 2016-05-31 15:03:03 UTC
Fixed upstream by commits:
b917969f75565bd02a690c371dc199df8cb126b7
40d1fff271fbcc039f8885be3915c0e112a35353

Comment 11 Xiaodai Wang 2016-07-01 07:01:35 UTC
I verified it with virt-viewer-2.0-9.el7.x86_64:

All the menu item below have mnemonic keys and all of them work well.
File->Screenshot
File->USB device selection
View->Displays
View->Displays->Display N
View->Fullscreen

So move the bug from ON_QA to VERIFIED.

Comment 13 errata-xmlrpc 2016-11-04 01:18:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2229.html


Note You need to log in before you can comment on or make changes to this bug.