Spec URL: https://jjames.fedorapeople.org/gap-pkg-factint/gap-pkg-factint.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-factint/gap-pkg-factint-1.5.3-1.fc25.src.rpm Fedora Account System Username: jjames Description: FactInt provides implementations of the following methods for factoring integers: - Pollard's p-1 - Williams' p+1 - Elliptic Curves Method (ECM) - Continued Fraction Algorithm (CFRAC) - Multiple Polynomial Quadratic Sieve (MPQS) FactInt also makes use of Richard P. Brent's tables of known factors of integers of the form bk+/-1 for "small" b. The ECM method is suited best for finding factors which are neither too small (i.e. have less than about 12 decimal digits) nor too close to the square root of the number to be factored. The MPQS method is designed for factoring products of two primes of comparable orders of magnitude. CFRAC is the historical predecessor of the MPQS method. Pollard's p-1 and Williams' p+1 are useful for finding factors p such that all prime factors of p-1 (respectively p+1) are "small", e.g. smaller than 1000000. All factoring methods implemented in this package are probabilistic. In particular the time needed by the ECM method depends largely on luck. FactInt provides a general-purpose factorization routine which uses an appropriate combination of the methods mentioned above, the Pollard Rho routine which is implemented in the GAP Library and a variety of tricks for special cases to obtain a good average performance for "arbitrary" integers. At the user's option, FactInt provides detailed information about the progress of the factorization process.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== * License not included in tarball - Checking the tarball reveals licensing details in factint.tex - Please request upstream issue an update with a specific license file in the tarball * Documentation in /usr - Accepted as a GAP practice due to the runtime doc browser * The PackageInfo specifies GAPDoc as required - GAPDoc-latex a BR but no GAPDoc as a require * Assuming package functions as described since %check passes * Some non utf-8 files found, please include these in your iconv in %prep * Since you do use iconv please include it in your BR to prevent issues should it be dropped from the generic build environment in future. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2196 files have unknown license. Detailed output of licensecheck in /home/james/workspace/fedora- scm/1332764-gap-pkg-factint/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [!]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [!]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-factint-1.5.3-1.fc25.noarch.rpm gap-pkg-factint-1.5.3-1.fc25.src.rpm gap-pkg-factint.noarch: W: only-non-binary-in-usr-lib gap-pkg-factint.noarch: W: file-not-utf8 /usr/lib/gap/pkg/factint/doc/abstract.xml gap-pkg-factint.noarch: W: file-not-utf8 /usr/lib/gap/pkg/factint/doc/general.xml gap-pkg-factint.noarch: W: file-not-utf8 /usr/lib/gap/pkg/factint/doc/factintbib.xml 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory gap-pkg-factint.noarch: W: invalid-url URL: http://www.gap-system.org/DevelopersPages/StefanKohl/factint.html <urlopen error [Errno -3] Temporary failure in name resolution> gap-pkg-factint.noarch: W: only-non-binary-in-usr-lib gap-pkg-factint.noarch: W: file-not-utf8 /usr/lib/gap/pkg/factint/doc/abstract.xml gap-pkg-factint.noarch: W: file-not-utf8 /usr/lib/gap/pkg/factint/doc/factintbib.xml gap-pkg-factint.noarch: W: file-not-utf8 /usr/lib/gap/pkg/factint/doc/general.xml 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- gap-pkg-factint (rpmlib, GLIBC filtered): gap-core Provides -------- gap-pkg-factint: gap-pkg-factint Source checksums ---------------- http://www.gap-system.org/pub/gap/gap4/tar.bz2/packages/factint-1.5.3.tar.bz2 : CHECKSUM(SHA256) this package : 1c66e326efe7cc93ccd4d54fd3aacebb7f304aa89bc46b5e7e9ae85241dfdb97 CHECKSUM(SHA256) upstream package : 1c66e326efe7cc93ccd4d54fd3aacebb7f304aa89bc46b5e7e9ae85241dfdb97 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1332764 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thank you for the review. (In reply to James Hogarth from comment #1) > * License not included in tarball > - Checking the tarball reveals licensing details in factint.tex > - Please request upstream issue an update with a specific license file > in the tarball Okay, will do. > * The PackageInfo specifies GAPDoc as required > - GAPDoc-latex a BR but no GAPDoc as a require Same as the gap-pkg-scscp review: GAPDoc is so fundamental that gap-core pulls it in, else GAP refuses to start. The GAPDoc-latex BR pulls in all of the LaTeX packages needed to actually build the documentation. > * Some non utf-8 files found, please include these in your iconv in %prep > * Since you do use iconv please include it in your BR to prevent issues > should it be dropped > from the generic build environment in future. Actually, I believe this is not the right thing to do. The first line of doc/factint.xml is: <?xml version="1.0" encoding="ISO-8859-1"?> So the encoding is specified. If you look at the build log for this package, you will see a line that looks like this: #I #I recoding input from ISO-8859-1 to UTF-8 . . . That line comes from GAPDoc (/usr/lib/gap/pkg/GAPDoc/lib/XMLParser.gi). GAPDoc has its own builtin encoding converter, so no need for iconv. The end result is HTML pages that are UTF-8 encoded, but we keep the source xml files around because GAPDoc wants them for some functions it provides.
Happy with responses and just double checked guidelines and agree this is acceptable. APPROVED
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-factint
gap-pkg-factint-1.5.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2c351067e
gap-pkg-factint-1.5.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2c351067e
gap-pkg-factint-1.5.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.