Bug 1332923 - Hosted engine deploy failed with error: TypeError: success() argument after ** must be a mapping, not str
Summary: Hosted engine deploy failed with error: TypeError: success() argument after *...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: 4.17.30
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ovirt-4.0.0-rc
: 4.18.0
Assignee: Piotr Kliczewski
QA Contact: Artyom
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-04 11:22 UTC by Artyom
Modified: 2016-07-05 07:49 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 07:49:46 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.0.0+
rule-engine: blocker+
rule-engine: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)
hosted engine setup log (264.67 KB, text/plain)
2016-05-04 11:22 UTC, Artyom
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 57017 0 master MERGED jsonrpc: change instance type to strings 2016-05-05 10:19:58 UTC

Description Artyom 2016-05-04 11:22:28 UTC
Created attachment 1153807 [details]
hosted engine setup log

Description of problem:
Hosted engine deploy failed with:
2016-05-04 11:56:52 DEBUG otopi.context context._executeMethod:142 method exception
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 132, in _executeMethod
    method['method']()
  File "/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py", line 1283, in _misc
    self._spmStart()
  File "/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py", line 1026, in _spmStart
    domVersion=version,
  File "/usr/lib/python2.7/site-packages/vdsm/jsonrpcvdscli.py", line 168, in _callMethod
    return response.success(**resp.result)
TypeError: success() argument after ** must be a mapping, not str

Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-2.0.0-0.0.master.20160503103744.gite1f03e3.el7.centos.noarch
vdsm-4.17.999-1036.git19a27af.el7.centos.noarch

How reproducible:
Always

Steps to Reproduce:
1. Deploy HE
2.
3.

Actual results:
Deployment failed with above error

Expected results:
Deployment succeeds without any errors

Additional info:
we have check under _callMethod
elif isinstance(resp.result, six.text_type):
                return response.success(resp.result)
but six.text_type connect only to unicode strings, I believe we just need to change it to six.string_types

Comment 1 Yaniv Kaul 2016-05-05 06:41:29 UTC
I assume it's a regression? An automation blocker?

Comment 2 Yaniv Kaul 2016-05-09 09:38:27 UTC
Artyom - if you've fixed it (kudos!) and the patch is merged, why is the bug on NEW? Can probably be verified and CLOSED-UPSTREAM.

Comment 3 Artyom 2016-05-10 06:07:27 UTC
I was sure we have some automation for this purpose, correct me if I wrong, so it must be moved to the POST, when the patch posted and to the MODIFIED when the patch merged.

Comment 4 Yaniv Kaul 2016-05-23 11:11:25 UTC
(In reply to Artyom from comment #3)
> I was sure we have some automation for this purpose, correct me if I wrong,
> so it must be moved to the POST, when the patch posted and to the MODIFIED
> when the patch merged.

Eyal?

Comment 5 Yaniv Lavi 2016-05-23 13:18:43 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 6 Yaniv Lavi 2016-05-23 13:25:41 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 7 Eyal Edri 2016-05-24 12:34:36 UTC
We don't enforce hooks for moving statues or enforcing bug-url on master branch.
This will be enabled once we branch 4.0 branch and will work on 3.6 and 4.0 branches.


usually master is too latest/greatest and enabling hooks that enforce validation might cause too much overhead, if we want to change that policy we need to raise it on devel and see what are the pro/cons.

Comment 8 Artyom 2016-06-05 13:31:54 UTC
Verified on ovirt-hosted-engine-setup-2.0.0-1.el7ev.noarch

Comment 9 Sandro Bonazzola 2016-07-05 07:49:46 UTC
oVirt 4.0.0 has been released, closing current release.


Note You need to log in before you can comment on or make changes to this bug.