Bug 1332944 – Different errors when trying to modify pod's .spec.container.resources

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1332944 - Different errors when trying to modify pod's .spec.container.resources

Summary:	Different errors when trying to modify pod's .spec.container.resources

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Master (Show other bugs)
Sub Component:
Version:	3.2.0
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Derek Carr
QA Contact:	weiwei jiang
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-05-04 08:02 EDT by Maciej Szulik
Modified:	2016-10-30 18:55 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-09-27 05:31:52 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:1933	normal	SHIPPED_LIVE	Red Hat OpenShift Container Platform 3.3 Release Advisory	2016-09-27 09:24:36 EDT

Groups: None (edit)

Description Maciej Szulik 2016-05-04 08:02:18 EDT

Description of problem:
Different errors when trying to modify pod's .spec.container.resources.

Version-Release number of selected component (if applicable):
OpenShift Master:
    v3.2.0.40
Kubernetes Master:
    v1.2.0-36-g4a3f9c5 


How reproducible:
Always


Steps to Reproduce:
1. Go to pods list
2. Choose one pod (eg. current deployment)
3. Click edit yaml
4. Try to modify container.resources.limits or container.resources.requests

Actual results:
Failed to update django-10-30bqb.
pods "django-10-30bqb" is forbidden: Unable to update quota status: compute-resources ResourceQuota "compute-resources" is invalid: [status.used[limits.cpu]: Invalid value: "-800m": must be greater than or equal to 0, status.used[limits.memory]: Invalid value: "-212Mi": must be greater than or equal to 0]

Expected results:
The same as from invoking oc edit pod/jango-10-30bqb:

# pods "django-10-30bqb" was not valid:
# * spec: Forbidden: pod updates may not change fields other than `containers[*].image` or `spec.activeDeadlineSeconds`

Comment 1 Jordan Liggitt 2016-05-06 10:03:28 EDT

Derek, should the resourcequota admission plugin even be processing the pod spec on update, since the spec isn't mutable?

Comment 2 Derek Carr 2016-05-06 10:21:56 EDT

ResourceQuota will ignore pod updates in kube 1.3+ with this PR:

https://github.com/kubernetes/kubernetes/pull/24514

Updating a pod container's resources will still cause a validation error.

Comment 3 Jordan Liggitt 2016-05-06 13:18:33 EDT

thanks, can you move to ON_QA once we pull in a level with this fix?

Comment 4 Derek Carr 2016-05-06 13:19:16 EDT

sure thing

Comment 6 weiwei jiang 2016-08-09 05:36:34 EDT

Checked with 
# openshift version 
openshift v3.3.0.17
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git
and console got the same error message 
Pod "pod-request-limit-valid-3" is invalid: spec: Forbidden: pod updates may not change fields other than `containers[*].image` or `spec.activeDeadlineSeconds`
with oc edit

Comment 8 errata-xmlrpc 2016-09-27 05:31:52 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1933

Note You need to log in before you can comment on or make changes to this bug.