Bug 1332986 - Snapshot operation names changed from <op_name>_snapshot to <op_name>snapshot
Summary: Snapshot operation names changed from <op_name>_snapshot to <op_name>snapshot
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.0.0-beta
: 4.0.0
Assignee: Juan Hernández
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-04 13:16 UTC by Raz Tamir
Modified: 2016-07-05 07:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 07:42:52 UTC
oVirt Team: Infra
rule-engine: ovirt-4.0.0+
rule-engine: blocker+
rule-engine: planning_ack+
juan.hernandez: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 57088 0 master MERGED restapi: Fix V3 snapshot action links 2016-05-06 11:19:19 UTC

Description Raz Tamir 2016-05-04 13:16:34 UTC 
Description of problem:
All snapshot operation changed:
 - preview_snapshot -> previewsnapshot
 - undo_snapshot -> undosnapshot
 - commit_snapshot -> commitsnapshot



Version-Release number of selected component (if applicable):
ovirt-engine-4.0.0-0.0.master.20160502171442.git6123627.el7.centos.noarch
vdsm-4.17.999-1036.git19a27af.el7.centos.noarch


How reproducible:
100%

Steps to Reproduce:
1. Run GET request on DELETE on /api/vms/{vm: id}
2. Search for preview
3.

Actual results:
previewsnapshot exists


Expected results:
should be preview_snapshot


Additional info:
Comment 1 Yaniv Kaul 2016-05-05 06:40:47 UTC 
Is that on the v4 API or the v3 API? If it's the v4, it's not a bug.
Comment 2 Raz Tamir 2016-05-05 07:36:49 UTC 
We are using V3 API
Comment 3 Allon Mureinik 2016-05-05 07:58:05 UTC 
I'm pretty sure this is intentional. Juan, can you weigh in here please?
Comment 4 Juan Hernández 2016-05-05 08:14:17 UTC 
The name change is intentional, and part of the changes in version 4 of the API. But version 3 of the API shouldn't be affected. I'm checking and fixing it.
Comment 5 Red Hat Bugzilla Rules Engine 2016-05-05 08:14:23 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 6 Yaniv Lavi 2016-05-09 10:53:47 UTC 
Moving to first RC, since things should not be targeted to second one at this point.
Comment 7 Raz Tamir 2016-06-15 14:40:05 UTC 
Verified on ovirt-engine-4.0.0.4-0.1.el7ev.noarch:
GET request to /api/vms/{vm_id}
<link href="/ovirt-engine/api/vms/{vm_id}/commit_snapshot" rel="commit_snapshot"/>
<link href="/ovirt-engine/api/vms/{vm_id}/preview_snapshot" rel="commit_snapshot"/>
<link href="/ovirt-engine/api/vms/{vm_id}/undo_snapshot" rel="commit_snapshot"/>
Comment 8 Sandro Bonazzola 2016-07-05 07:42:52 UTC 
oVirt 4.0.0 has been released, closing current release.
Note You need to log in before you can comment on or make changes to this bug.