Bug 1332999 - Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them to Python objects
Summary: Review Request: python-xunitparser - Read JUnit/XUnit XML files and map them ...
Keywords:
Status: CLOSED DUPLICATE of bug 1333525
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-04 13:42 UTC by Lukas Brabec
Modified: 2016-07-29 09:40 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-24 19:40:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Lukas Brabec 2016-05-04 13:42:57 UTC
Spec URL: https://lbrabec.fedorapeople.org/python-xunitparser.spec
SRPM URL: https://lbrabec.fedorapeople.org/python-xunitparser-1.3.3-1.fc24.src.rpm
Description: Read JUnit/XUnit XML files and map them to Python objects
Fedora Account System Username: lbrabec

Comment 1 Lukas Brabec 2016-05-04 13:45:24 UTC
This is my first package, so I need sponsor.


We need this package for Taskotron [1], to parse XML output of pytest and unittest.

[1] https://taskotron.fedoraproject.org/

Comment 2 Stanislav Ochotnicky 2016-05-04 14:06:29 UTC
The package looks good to me generally - pretty small/clean. Why no Python 3 though? It seems to build fine

Comment 3 Lukas Brabec 2016-05-04 14:22:36 UTC
I initially included python3 but I found that `python3 setup.py test` fails in several testcases. I decided not to include python3 until the testsuite passes without failures or errors.

Comment 4 Michael Cullen 2016-05-04 23:44:22 UTC
*Unofficial comments - I too am waiting for a sponsor *

Minor, mostly personal choice point first: you don't need the "sum" global - just include the summary in the header as usual and then use %{summary} where you need it. Though having said that, the python sample spec file does it your way. I just like keeping extra macros to a minimum.

The Group tag is not needed [1]

Ideally the description would be a little bit more than just the summary

rpmlint is clean, which is good

license looks fine


[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

Comment 6 Thomas Spura 2016-05-08 00:00:15 UTC
In bug #1333525 it is mentioned that the python3 failures have been reported to upstream. There isn't anything about the status of the fixes, though.

Comment 7 Tim Flink 2016-05-23 13:55:30 UTC
Has the duplication between this and #1333525 been figured out? It looks like slightly more progress has been made on that review but it's yet to be completed

Comment 8 Mairi Dulaney 2016-05-24 19:04:15 UTC
As an aside, you may want to ping ignatenkobrain on IRC (Freenode) and see about becoming a co-maintainer, as he also submitted a review for this package, and his was granted.

Comment 9 Tim Flink 2016-05-24 19:40:53 UTC
(In reply to John Dulaney from comment #8)
> As an aside, you may want to ping ignatenkobrain on IRC (Freenode) and see
> about becoming a co-maintainer, as he also submitted a review for this
> package, and his was granted.

That's already been taken care of. Not sure why this hasn't been closed as duplicate yet.

Closing, please re-open if I misunderstood something

*** This bug has been marked as a duplicate of bug 1333525 ***


Note You need to log in before you can comment on or make changes to this bug.