Bug 1333163 - YAML editor throws error when trying to search
Summary: YAML editor throws error when trying to search
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.2.1
Assignee: Samuel Padgett
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-04 19:53 UTC by Samuel Padgett
Modified: 2016-06-27 15:06 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
When editing a YAML object in the web console, pressing CTRL+F or CMD+F to attempt to search the text did not appear to do anything. This bug fix updates the web console so that doing so causes a search box to appear in the UI, as expected.
Clone Of:
Environment:
Last Closed: 2016-06-27 15:06:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Dev tools error screenshot (396.96 KB, image/png)
2016-05-04 19:53 UTC, Samuel Padgett
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1343 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 3.2.1.1 bug fix and enhancement update 2016-06-27 19:04:05 UTC

Description Samuel Padgett 2016-05-04 19:53:34 UTC
Created attachment 1153999 [details]
Dev tools error screenshot

Edit YAML of a resource. Press Cmd-F on Mac (probably Ctrl-F on other platforms). Nothing happens.

In the console, I see a JS error (b is undefined).

f.loadModule("ace/ext/searchbox", function(b) {
b.Search(a);

Comment 1 Samuel Padgett 2016-05-09 14:44:04 UTC
https://github.com/openshift/origin/pull/8794

Comment 3 Yadan Pei 2016-05-20 10:10:17 UTC
Will check when new puddle is available

Comment 4 Yadan Pei 2016-05-26 01:48:14 UTC
Since target release is 3.2.1, will check when 3.2.1 puddle is ready

Comment 5 Yadan Pei 2016-05-26 09:58:51 UTC
$ git log --pretty="%h %an %cd - %s" --date=local enterprise-3.2 | grep 'dbfbaf2'
$ git log --pretty="%h %an %cd - %s" --date=local master | grep 'dbfbaf2'
dbfbaf2 Samuel Padgett Tue May 10 05:51:35 2016 - Include ext-searchbox.js for Ace editor search

PR is not merged to enterprise-3.2, so could not test against v3.2.0.45 puddle(latest puddle), move to MODIFIED

Comment 7 Yadan Pei 2016-06-06 08:56:37 UTC
Checked against 
openshift v3.2.1.1-1-g33fa4ea
kubernetes v1.2.0-36-g4a3f9c5
etcd 2.2.5

Now when use CTRL+F(on windows,fedora) and Cmd-F(on Mac) in YAML editor, a search box appears, user could search in the editor using RegExp Search, Case Sensitive Search, Whole Word Search

It works well

Comment 9 errata-xmlrpc 2016-06-27 15:06:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1343


Note You need to log in before you can comment on or make changes to this bug.