Description of problem: If a command has a backslash within quotes, and that command is brought back with e.g. "up-history", the backslash is doubled. Version-Release number of selected component (if applicable): tcsh-6.19.00-7.fc24.x86_64 How reproducible: Every time Steps to Reproduce: 1. echo '\n' 2. <Up> (or ctrl-p) Actual results: The line says: echo '\\n' Expected results: A line saying: echo '\n'
Göran, I'm not able to reproduce this (f24 mock with 6.19.00-7). Seems like there is some missing step in the reproducer?
(In reply to Pavel Raiskup from comment #1) Just type "\" followed by <Enter> and recall the (last) command using the history function.
I am able to reproduce it on f23 if I just compile the f24 version of tcsh: kdudka@f23 ~/fedora/tcsh/tcsh-6.19.00 $ ./tcsh [kdudka@f23 tcsh-6.19.00]$ echo '\n' [kdudka@f23 tcsh-6.19.00]$ echo '\\n' After commenting out tcsh-6.19.00-026-quote-backslashes-properly.patch, the bug is no longer reproducible: kdudka@f23 ~/fedora/tcsh/tcsh-6.19.00 $ ./tcsh [kdudka@f23 tcsh-6.19.00]$ echo '\n' [kdudka@f23 tcsh-6.19.00]$ echo '\n'
Pawel, did the examples from Joachim and Kamil help you to reproduce? If not, and to be very explicit, these are the keys I type in my example e c h o SPACE ' \ n ' ENTER UP-ARROW If you do the same, do you see one or two backslashes? To be on the safe side, I tried it in a shell started with the -f flag, and I could still reproduce it.
Ah, sorry - it is clearly reproducible: $ mock -r fedora-rawhide-x86_64 --install tcsh $ mock -r fedora-rawhide-x86_64 --shell <mock-chroot> sh-4.3# tcsh [root@nb /]# echo '\n' [root@nb /]# echo '\\n' \n [root@nb /]# echo '\\\\n' \\n [root@nb /]# echo '\\\\\\\\n' \\\\n
I have already informed upstream about this: http://mx.gw.com/pipermail/tcsh-bugs/2016-May/001043.html
Created attachment 1155760 [details] proposed-patch The patch seems to be an EasyFix (one liner). It fixes the regression, testsuite passes, as well as the testcase for the initial issue.
Upstream has published fix for this regression: https://github.com/tcsh-org/tcsh/commit/d52d669405da I have already included the changes in Rawhide & F24: http://pkgs.fedoraproject.org/cgit/rpms/tcsh.git/commit/?d=4fa96ac1048b5f5a New package build is on the way, so stay tuned! ;)
tcsh-6.19.00-8.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-16167118e0
Comment on attachment 1155760 [details] proposed-patch Upstream fixed the issue in different part of source code.
tcsh-6.19.00-8.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-16167118e0
tcsh 6.19.00-8.fc24 fixes this bug.
tcsh-6.19.00-8.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.