Bug 1333742 - imgbased --version info is not consistent with imgbased rpm version
Summary: imgbased --version info is not consistent with imgbased rpm version
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-node
Classification: oVirt
Component: Installation & Update
Version: 4.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.1.1
: 4.1
Assignee: Yuval Turgeman
QA Contact: jianwu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-06 09:41 UTC by Ying Cui
Modified: 2017-04-21 09:32 UTC (History)
10 users (show)

Fixed In Version: imgbased-0.7.2-0.1.el7ev
Clone Of:
Environment:
Last Closed: 2017-04-21 09:32:34 UTC
oVirt Team: Node
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
fdeutsch: devel_ack+
ycui: testing_ack+


Attachments (Terms of Use)
var_log (4.71 MB, application/x-bzip)
2016-05-06 09:51 UTC, Ying Cui
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 60374 0 master MERGED version: config.version should match what's used by RPM 2016-07-07 18:23:44 UTC
oVirt gerrit 71154 0 master MERGED Modified imgbase to display correct version 2017-01-27 08:43:41 UTC
oVirt gerrit 71294 0 ovirt-4.1 MERGED Modified imgbase to display correct version 2017-01-27 08:54:29 UTC

Description Ying Cui 2016-05-06 09:41:26 UTC
Description of problem:
imgbased version information is not consistent

 "# rpm -qa imgbased" vs. "# imgbase --version"

Version-Release number of selected component (if applicable):
rhev-hypervisor7-ng-3.6-20160429.0
imgbased-0.6-0.1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. Install rhev-hypervisor7-ng-3.6-20160429.0
2. Check

# rpm -qa imgbased
imgbased-0.6-0.1.el7ev.noarch

# imgbase --version
imgbased-0.6-git1e3b28f


Actual results:
imgbased version information is not consistent.

Expected results:
imgbased version information should be consistent

like kernel does
# uname -r
3.10.0-327.13.1.el7.x86_64
# rpm -qa kernel
kernel-3.10.0-327.13.1.el7.x86_64

Comment 1 Ying Cui 2016-05-06 09:51:55 UTC
Created attachment 1154542 [details]
var_log

Comment 2 Ying Cui 2016-06-23 02:06:04 UTC
It is not fixed in ovirt-node-ng-installer-ovirt-4.0-snapshot-2016062108.iso

# md5sum ovirt-node-ng-installer-ovirt-4.0-snapshot-2016062108.iso 
b23e44452c2d70f02cb6f32f8aeabcf6  ovirt-node-ng-installer-ovirt-4.0-snapshot-2016062108.iso

Interactive installed this iso successful, after reboot, checking the following:

# rpm -qa imgbased
imgbased-0.7.0-0.201606170910git3cb1db2.el7.centos.noarch
# imgbase --version
imgbased-0.7.0-gitimgbased-0.7-10-g3cb1db2

Result:
imgbased version information is not consistent.

Comment 3 Fabian Deutsch 2016-06-23 10:33:57 UTC
My bad, I accidentally moved it to ON_QA.

Comment 4 Fabian Deutsch 2016-07-28 06:27:18 UTC
The solution needs some additional work.

Comment 5 Fabian Deutsch 2017-01-05 14:42:10 UTC
The remaining issue is that --versin out put is wrong:

# imgbase --version
imgbased-0.7.0-gitimgbased-0.7-10-g3cb1db2

Otherwise the packaging NVR and --version output correlate enough - they will never be the same - because they are two different things (package version and binary version).

Comment 6 cshao 2017-03-02 08:32:35 UTC
Test version:
redhat-virtualization-host-4.1-20170222.0 
imgbased-0.9.13-0.1.el7ev.noarch

# rpm -qa imgbased
imgbased-0.9.13-0.1.el7ev.noarch

# imgbase --version
imgbased-0.9.13

Test result:
imgbased version information is not identical, so the bug is partial fixed, change bug status to ASSIGNED.

Comment 7 Red Hat Bugzilla Rules Engine 2017-03-02 08:32:43 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 Yuval Turgeman 2017-03-02 08:52:41 UTC
(In reply to shaochen from comment #6)
> Test version:
> redhat-virtualization-host-4.1-20170222.0 
> imgbased-0.9.13-0.1.el7ev.noarch
> 
> # rpm -qa imgbased
> imgbased-0.9.13-0.1.el7ev.noarch
> 
> # imgbase --version
> imgbased-0.9.13
> 
> Test result:
> imgbased version information is not identical, so the bug is partial fixed,
> change bug status to ASSIGNED.

It shouldn't be the same as the RPM, we follow a standard --version scheme so if we take python for example:

[yturgema@piggie ~]$ rpm -q python
python-2.7.13-1.fc25.x86_64
[yturgema@piggie ~]$ python --version
Python 2.7.13

Comment 9 cshao 2017-03-02 08:55:54 UTC
> It shouldn't be the same as the RPM, we follow a standard --version scheme
> so if we take python for example:
> 
> [yturgema@piggie ~]$ rpm -q python
> python-2.7.13-1.fc25.x86_64
> [yturgema@piggie ~]$ python --version
> Python 2.7.13

Thanks for reminding, please help move back bug status to ON_QA, I will verify it.

Comment 10 cshao 2017-03-02 09:06:41 UTC
Verify this bug according #c8.


Note You need to log in before you can comment on or make changes to this bug.