Bug 1333818 - python-gerritlib: Provide a Python 3 subpackage
Summary: python-gerritlib: Provide a Python 3 subpackage
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-gerritlib
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kashyap Chamarthy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: PYTHON3 PY3PATCH-PUSH
TreeView+ depends on / blocked
 
Reported: 2016-05-06 13:23 UTC by Tomas Orsava
Modified: 2016-09-07 11:38 UTC (History)
5 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2016-09-07 11:38:45 UTC


Attachments (Terms of Use)
0001-update-python-and-gerritlib.patch (2.83 KB, patch)
2016-07-15 20:04 UTC, dima
no flags Details | Diff
New upstream version, modernized specfile, Python2/3 subpackages (3.85 KB, patch)
2016-08-26 13:18 UTC, Lumír Balhar
no flags Details | Diff
New upstream version, modernized specfile, Python2/3 subpackages (3.96 KB, patch)
2016-08-26 13:45 UTC, Lumír Balhar
no flags Details | Diff

Description Tomas Orsava 2016-05-06 13:23:40 UTC
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's OK to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If you need more instructions, a guide for porting Python-based RPMs is
available at [2].
If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
[2] http://python-rpm-porting.readthedocs.io/

Comment 1 Dominika Krejčí 2016-06-06 13:27:07 UTC
Hello Kashyap,

do you need any help adding Python 3 support to the RPM?

Comment 2 Kashyap Chamarthy 2016-06-06 14:17:36 UTC
(In reply to Dominika Krejčí from comment #1)
> Hello Kashyap,
> 
> do you need any help adding Python 3 support to the RPM?

Hi Dominika,

Sorry, I'm quite occupied with other priorities, and not able to get to this immediately.

If you have time, and want to pick up the Python 3 work, please go for it.  I could add you as a co-mainatiner if you like.

Comment 3 dima 2016-07-15 20:04 UTC
Created attachment 1180262 [details]
0001-update-python-and-gerritlib.patch

hello
i update gerritlib and for fedora it will build for python3

Comment 4 Jan Kurik 2016-07-26 04:29:36 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 5 Lumír Balhar 2016-08-02 09:27:49 UTC
Hello Dmitry.

Could you please make a new patch? In current one there are a lot of issues which I mentioned before in previous reviews. The biggest one is that this package isn't separated for python2/3.

Thank you and have a nice day.

Comment 6 Lumír Balhar 2016-08-26 13:18 UTC
Created attachment 1194341 [details]
New upstream version, modernized specfile, Python2/3 subpackages

Hello.

I am providing new patch for specfile with new upstream release, modernized specfile and Python 2/3 subpackages.

Comment 7 Lumír Balhar 2016-08-26 13:28:12 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=15387194

Comment 8 Tomas Orsava 2016-08-26 13:37:14 UTC
Hi Lumir!

Just one note: add the %python_provide macros for the subpackages.
Besides that it looks good!

Comment 9 Lumír Balhar 2016-08-26 13:45 UTC
Created attachment 1194343 [details]
New upstream version, modernized specfile, Python2/3 subpackages

Thanks Tomas for review.

I've added 'provide' macro and new patch is attached.

If maintainer has nothing against, we can push this change after a week.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15387790


Note You need to log in before you can comment on or make changes to this bug.