Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-1.fc23.src.rpm Description: Clonk is a multiplayer-action-tactics-skill game. It is often referred to as a mixture of The Settlers and Worms. In a simple 2D antfarm-style landscape, the player controls his crew of Clonks, small but robust humanoid beings. The game encourages free play but the normal goal is to either exploit valuable resources from the earth by building a mine or fight each other on an arena-like map. Fedora Account System Username: sagitter
*** Bug 1186503 has been marked as a duplicate of this bug. ***
In reply to https://bugzilla.redhat.com/show_bug.cgi?id=1186503#c14: > > and Clonk Game Content License > > http://www.clonk.de/developer.php?lng=en > > Creative Commons Attribution-NonCommercial (CC BY-NC) > > http://creativecommons.org/licenses/by-nc/4.0/ > > > > which License tag should i use now ? > > As far as I can evaluate, the license tag has to be "ISC and CC-BY-NC". but > have a look at the tables in the licensing guidelines: > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3 > The Creative Commons Attribution-NonCommercial License is mentioned there as > a "bad license" (maybe due to inacceptable restrictions). So I'm afraid this > package is only releasable in RPMfusion. http://wiki.openclonk.org/w/FAQ#What_is_the_license_for_OpenClonk.3F CC-BY-SA is a good license for Fedora. > $ licensecheck -r * | grep BSD > thirdparty/getopt/getopt_long.c: BSD (3 clause) > thirdparty/getopt/getopt.c: BSD (3 clause) > > This refers to bundled stuff. We don't use this, we need to pull the getopt > development files from the build system. This also means you still have to > remove thirdparty/getopt, better the whole thirdparty directory to be on > safer side. Maybe a patch is needed to use the local getopt instead of the > bundled one. Where are getopt files on Fedora?
(In reply to Antonio Trande from comment #2) > In reply to https://bugzilla.redhat.com/show_bug.cgi?id=1186503#c14: > > Where are getopt files on Fedora? # rpm -qf /usr/include/getopt.h glibc-headers-2.22-11.fc23.x86_64
(In reply to MartinKG from comment #3) > (In reply to Antonio Trande from comment #2) > > In reply to https://bugzilla.redhat.com/show_bug.cgi?id=1186503#c14: > > > > Where are getopt files on Fedora? > > # rpm -qf /usr/include/getopt.h > glibc-headers-2.22-11.fc23.x86_64 repoquery did not found it ... Okay, I'm going to fix.
Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-2.fc23.src.rpm - Unbundle getopt - Strip all .png files - Make an appdata file
Issues: ======= - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in openclonk See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database
(In reply to MartinKG from comment #6) > Issues: > ======= > - update-desktop-database is invoked in %post and %postun if package > contains desktop file(s) with a MimeType: entry. > Note: desktop file(s) with MimeType entry in openclonk > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > database Are there. %post /bin/touch --no-create %{_datadir}/mime/packages &>/dev/null || : /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || : /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || : /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database wiki points me to this: Use this when a desktop entry has a 'MimeType key. %post /usr/bin/update-desktop-database &> /dev/null || : %postun /usr/bin/update-desktop-database &> /dev/null || :
Yes, sorry; my bad. Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-2.fc23.src.rpm
could you please create a devel-docs subpkg like the rpmfusion package ? https://github.com/rpmfusion/openclonk/blob/master/openclonk.spec
(In reply to MartinKG from comment #10) > could you please create a devel-docs subpkg like the rpmfusion package ? > https://github.com/rpmfusion/openclonk/blob/master/openclonk.spec I did not know it was on RPMFusion. It is release under "ISC and CC-BY-SA", i see; why it's not on Fedora ?
The license status was not clear at this time.(In reply to Antonio Trande from comment #11) > (In reply to MartinKG from comment #10) > > could you please create a devel-docs subpkg like the rpmfusion package ? > > https://github.com/rpmfusion/openclonk/blob/master/openclonk.spec > > I did not know it was on RPMFusion. > It is release under "ISC and CC-BY-SA", i see; why it's not on Fedora ? The license status was not clear at this time, now it is time that it is taken up by Fedora.
Spec URL: https://sagitter.fedorapeople.org/openclonk/openclonk.spec SRPM URL: https://sagitter.fedorapeople.org/openclonk/openclonk-7.0-3.fc23.src.rpm - Made sub-package for documentation > The license status was not clear at this time, now it is time that it is taken up by Fedora. We can maintain it together, but it should be retired by RPM Fusion.
(In reply to Antonio Trande from comment #13) > > We can maintain it together, but it should be retired by RPM Fusion. filled bug report on rpmfusion: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4052
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4792320 bytes in 1260 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT/X11 (BSD like)", "zlib/libpng", "BSL", "GPL (v2 or later) (with incorrect FSF address)", "ISC". 1304 files have unknown license. Detailed output of licensecheck in /home/martin/rpmbuild/SPECS/openclonk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in openclonk [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in openclonk [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openclonk-data , openclonk-devel-docs , openclonk-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: openclonk-7.0-3.fc25.x86_64.rpm openclonk-data-7.0-3.fc25.noarch.rpm openclonk-devel-docs-7.0-3.fc25.noarch.rpm openclonk-debuginfo-7.0-3.fc25.x86_64.rpm openclonk-7.0-3.fc25.src.rpm openclonk.x86_64: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer openclonk.x86_64: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer openclonk.x86_64: W: spelling-error %description -l en_US antfarm -> ant farm, ant-farm, farmland openclonk.x86_64: W: no-manual-page-for-binary openclonk openclonk.x86_64: W: no-manual-page-for-binary c4group openclonk-data.noarch: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer openclonk-data.noarch: W: no-documentation openclonk-devel-docs.noarch: W: desktopfile-without-binary /usr/share/applications/openclonk-html-de.desktop xdg-open openclonk-devel-docs.noarch: W: desktopfile-without-binary /usr/share/applications/openclonk-html-en.desktop xdg-open openclonk.src: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer openclonk.src: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer openclonk.src: W: spelling-error %description -l en_US antfarm -> ant farm, ant-farm, farmland openclonk.src:50: W: unversioned-explicit-provides bundled(timsort) 5 packages and 0 specfiles checked; 0 errors, 13 warnings. Rpmlint (debuginfo) ------------------- Checking: openclonk-debuginfo-7.0-3.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory openclonk.x86_64: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer openclonk.x86_64: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer openclonk.x86_64: W: spelling-error %description -l en_US antfarm -> ant farm, ant-farm, farmland openclonk.x86_64: W: no-manual-page-for-binary openclonk openclonk.x86_64: W: no-manual-page-for-binary c4group openclonk-data.noarch: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer openclonk-data.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 7 warnings. Requires -------- openclonk (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libGL.so.1()(64bit) libGLEW.so.1.13()(64bit) libGLU.so.1()(64bit) libX11.so.6()(64bit) libXrandr.so.2()(64bit) libalut.so.0()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libixml.so.2()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libogg.so.0()(64bit) libopenal.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libthreadutil.so.6()(64bit) libtinyxml.so.0()(64bit) libupnp.so.6()(64bit) libvorbis.so.0()(64bit) libvorbisfile.so.3()(64bit) libz.so.1()(64bit) openclonk-data rtld(GNU_HASH) openclonk-data (rpmlib, GLIBC filtered): openclonk openclonk-devel-docs (rpmlib, GLIBC filtered): xdg-utils openclonk-debuginfo (rpmlib, GLIBC filtered): Provides -------- openclonk: appdata() appdata(openclonk.appdata.xml) application() application(openclonk.desktop) bundled(timsort) mimehandler(x-scheme-handler/clonk) openclonk openclonk(x86-64) openclonk-data: openclonk-data openclonk-devel-docs: application() application(openclonk-html-de.desktop) application(openclonk-html-en.desktop) openclonk-devel-docs openclonk-debuginfo: openclonk-debuginfo openclonk-debuginfo(x86-64) Source checksums ---------------- https://github.com/openclonk/openclonk/archive/v7.0.tar.gz#/openclonk-7.0.tar.gz : CHECKSUM(SHA256) this package : 8c31e56a551d964e117bff10ca30b89d9618657fc0aeeb093043210a4cc89d11 CHECKSUM(SHA256) upstream package : 8c31e56a551d964e117bff10ca30b89d9618657fc0aeeb093043210a4cc89d11 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -x CheckOwnDirs -rn ../SRPMS/openclonk-7.0-3.fc24.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package approved.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0e1d10a348 https://bodhi.fedoraproject.org/updates/FEDORA-2016-4ce3af54eb